Add tests for node/add when no node types exist

A full test of the node/add functionality would include testing for users with and without 'administer content types'. For users with the 'administer content types' permission we should be using WebTest's click link functionality to test that the expected link is there.

Cottser's patch in #2073811: Add a url generator twig extension is fine and works it's @dawehner's patch that exposed the missing test coverage.

Nice work - a few minor things to keep the test as simple and reliable as possible.

1. +++ b/core/modules/node/src/Tests/NodeCreationTest.php
   @@ -158,4 +158,30 @@ public function testAuthorAutocomplete() {
   +  function testNodeCreationWithoutContentTypes() {
   

   Lets call this testNodeAddWithoutContentTypes since you're not creating a node.

2. +++ b/core/modules/node/src/Tests/NodeCreationTest.php
   @@ -158,4 +158,30 @@ public function testAuthorAutocomplete() {
   +    // Test /node/add page without content types.
   +    foreach (entity_load_multiple('node_type') as $entity ) {
   +      $entity->delete();
   +    }
   +
   +    $this->drupalGet('node/add');
   +    $this->assertResponse(403);
   

   I would assert that the current user can get to node/add before deleting the content types - in it's current state this seems a bit brittle.

3. +++ b/core/modules/node/src/Tests/NodeCreationTest.php
   @@ -158,4 +158,30 @@ public function testAuthorAutocomplete() {
   +    $this->assertUrl('node/add');
   ...
   +    $this->assertUrl('node/add');
   

   You only really need to do this is you are expecting the url to be different as is the case in testNodeCreation

4. +++ b/core/modules/node/src/Tests/NodeCreationTest.php
   @@ -158,4 +158,30 @@ public function testAuthorAutocomplete() {
   +    $this->drupalGet('admin/structure/types/add');
   +    $this->assertResponse(200);
   +    $this->assertUrl('/admin/structure/types/add');
   

   We don't need to actually go to the node type add page - this is tested elsewhere.

Nearly perfect! Just a couple of very very minor nitpicks.

+++ b/core/modules/node/src/Tests/NodeCreationTest.php
@@ -158,4 +158,27 @@ public function testAuthorAutocomplete() {
+    $this->drupalGet('node/add');
+    $this->assertResponse(200);
+
+    $this->assertLinkByHref('/admin/structure/types/add', 0);

Actually there is no need to assert the 200 here if you are going to assert the link. And the assertLinkByHref's second argument is not needed. The default is 0.

Great! Thank you.

Good point @dawehner

Thanks!