From our CSS guidelines:

If a property does not require quotes (e.g. url(), do not add them. This means background-image: url(path/image.png) instead of background-image: url("path/image.png")

To-do:
- Review the patch from #3.

CommentFileSizeAuthor
#6 2309137-remove-url-quotes-6.patch13.26 KBlewisnyman
#4 2309137-remove-url-quotes-4.patch13.97 KBlongwave
#3 remove-url-quotes-2309137-3.patch1.22 KBsqndr

Comments

sqndr’s picture

sqndr commented
Assigned: Unassigned » sqndr

I'll fix this ;)

sqndr’s picture

sqndr commented
Issue summary: View changes

I've updated the documentation with a beter example, so I'm changing the quote here.

sqndr’s picture

sqndr commented
Issue summary: View changes
StatusFileSize
new remove-url-quotes-2309137-3.patch1.22 KB

Removed the quotes in the css from Bartik. Only found 3 lines; so a very small patch here ;) Looks like it's al out now: http://cl.ly/image/2W132A1p2o1g

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Component: Bartik theme » CSS
StatusFileSize
new 2309137-remove-url-quotes-4.patch13.97 KB

We should do this for all CSS, not just Bartik.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
lewisnyman’s picture

lewisnyman
he/him
commented
StatusFileSize
new 2309137-remove-url-quotes-6.patch13.26 KB

We should do this for all CSS, not just Bartik.

Yeah, I was just worried that it would be too big a patch to manage in one go. It doesn't look too bad.

Having said that, I found a few more instances where we use background-image with quotes. I've updated the patch.

lewisnyman’s picture

lewisnyman
he/him
commented
Status: Needs review » Reviewed & tested by the community

Nope, sorry, my mistake. Don't review patches before coffee. Patch #4 is fine.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed b015229 and pushed to 8.x. Thanks!

  • alexpott committed b015229 on 8.x 
    Issue #2309137 by longwave, sqndr | LewisNyman: Remove quotes from all...
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented

We should do this for all CSS, not just Bartik.

Was there another followup to get any remaining css outside seven and bartik? Or did this get them all?

NM. should have actually looked at the patch before commenting :P I guess this got everything!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.