Remove trailing whitespace.

CommentFileSizeAuthor
#1 webform_whitespace_2308589.patch2.38 KBliam morland

Comments

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Assigned: liam morland » Unassigned
Status: Active » Needs review
StatusFileSize
new webform_whitespace_2308589.patch2.38 KB
danchadwick’s picture

danchadwick commented

I suppose. I hate deleting spaces at the end of word-wrapped docblock comments. It makes it harder to re-wrap when you edit them. My IDE doesn't seem to have a docblock re-wrap function.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

My editor removes trailing space by default to help follow coding standards, so it is a hassle when there is trailing space because ever patch includes un-related whitespace changes. The patch above, by the way, covers all trailing whitespace in Webform.

danchadwick’s picture

danchadwick commented
Priority: Normal » Minor
Status: Needs review » Fixed

Thanks, Liam. Committed to 7.x-4.x and 8.x.

One tiny suggestion: The patch naming convention is 

webform-issue_description_goes_here-123456-1.patch

This makes it a little easier for me (note the dash after webform and the inclusion of the comment number).

I changed my editor to clean the whitespace ONLY from the lines I change. If your IDE has the same option, it might prevent you from suffering and still not induce suffering in others. Seems like the best of both worlds.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

I changed my editor to clean the whitespace ONLY from the lines I change.

My editor doesn't have that option. It's a good idea, however.

Thanks for pointing out the file naming convention.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

The commit in #7 is for #2304047: PDO Exception: Duplicate entry for key 'nid_serial'.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.