On the "Image size" field:

Double-escape-age

Files: 

Comments

webchick’s picture

Status: Active » Needs review
FileSize
1016 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 74,906 pass(es). View

Well, this is probably not right, but seems to fix the problem and follows the pattern used in the upstream patch in e.g. install_finished().

webchick’s picture

"After" screenshot.

Inline fields.

Wim Leers’s picture

Title: HTML double-escaping on CKEditor image pop-up » HTML double-escaping in EditorImageDialog
Component: ckeditor.module » editor.module
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

Perfect — thanks :)

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 16a429e and pushed to 8.x. Thanks!

  • alexpott committed 16a429e on 8.x
    Issue #2307125 by webchick: Fixed HTML double-escaping in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

chx’s picture

Priority: Normal » Major
Status: Closed (fixed) » Active
Issue tags: -Twig, -Quickfix

This needs to be redone and SafeMarkup::set removed.

longwave’s picture

Why? What is unsafe about the fixed strings used here?

chx’s picture

Please see the parent issue for a more proper fix. (btw all this prefix/suffix business is really ugly and hardly belongs to any modules.)

longwave’s picture

Status: Active » Needs review
FileSize
1.11 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 75,406 pass(es). View

The required number of classes seems a bit unwieldy but they are all required for different reasons.

Wim Leers’s picture

Status: Needs review » Reviewed & tested by the community

Beautiful. I didn't know form-composite existed. Thank you!

(Manually tested, works great.)

chx’s picture

That's much better, thanks.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 65d7cc5 and pushed to 8.0.x. Thanks!

  • alexpott committed 65d7cc5 on 8.0.x
    Issue #2307125 followup by longwave: Fixed HTML double-escaping in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jibran’s picture

Issue tags: +SafeMarkup