On the "Image size" field:

Double-escape-age

CommentFileSizeAuthor
#10 2307125-editorimagedialog-remove-safemarkup.patch1.11 KBlongwave
#2 Screen Shot 2014-07-21 at 12.18.36 PM.png10.12 KBwebchick
#1 drupal-ckeditor-image-double-escape-2307125-1.patch1016 byteswebchick
Screen Shot 2014-07-21 at 12.06.01 PM.png13.66 KBwebchick
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Active » Needs review
FileSize
drupal-ckeditor-image-double-escape-2307125-1.patch1016 bytes

Well, this is probably not right, but seems to fix the problem and follows the pattern used in the upstream patch in e.g. install_finished().

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
FileSize
Screen Shot 2014-07-21 at 12.18.36 PM.png10.12 KB

"After" screenshot.

Inline fields.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Title: HTML double-escaping on CKEditor image pop-up » HTML double-escaping in EditorImageDialog
Component: ckeditor.module » editor.module
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

Perfect — thanks :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 16a429e and pushed to 8.x. Thanks!

  • alexpott committed 16a429e on 8.x 
    Issue #2307125 by webchick: Fixed HTML double-escaping in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

chx’s picture

chx CreditAttribution: chx commented
Priority: Normal » Major
Status: Closed (fixed) » Active
Issue tags: -Twig, -Quickfix

This needs to be redone and SafeMarkup::set removed.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented

Why? What is unsafe about the fixed strings used here?

chx’s picture

chx CreditAttribution: chx commented

Please see the parent issue for a more proper fix. (btw all this prefix/suffix business is really ugly and hardly belongs to any modules.)

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Active » Needs review
FileSize
2307125-editorimagedialog-remove-safemarkup.patch1.11 KB

The required number of classes seems a bit unwieldy but they are all required for different reasons.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Needs review » Reviewed & tested by the community

Beautiful. I didn't know form-composite existed. Thank you!

(Manually tested, works great.)

chx’s picture

chx CreditAttribution: chx commented

That's much better, thanks.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 65d7cc5 and pushed to 8.0.x. Thanks!

  • alexpott committed 65d7cc5 on 8.0.x 
    Issue #2307125 followup by longwave: Fixed HTML double-escaping in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Issue tags: +SafeMarkup