Closed (fixed)
Project:
Views (for Drupal 7)
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
18 Jul 2014 at 17:24 UTC
Updated:
27 Aug 2014 at 07:10 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
olli commentedI think this same bug exists in 7.x.
Comment #2
jhodgdonI tested the 8.x patch in #1. It works great! I tested it manually using a variety of add and edit dialogs, and it correctly displayed or didn't display the "changed" message at the right times.
And you're right, the same bug exists in Views 7.x -- I just never noticed it before, amazingly, because I use Views all the time. In 7.x, incidentally, besides putting up the "changed" message, Views UI thinking the view has changed also makes the Save button visible. This behavior is not replicated in 8.x.
The code in this patch has a minor formatting problem:
Needs an extra blank line inserted here between the new __construct() function and the next function.
And here:
There is extra space in this line after ==>
Comment #3
amitgoyal commentedPlease review updated patch with formatting fixes as per #2.
Comment #4
jhodgdonLooks good to me! The code formatting is correct now, and I tested the patch with the same code in it previously (only changes were whitespace).
I hesitate to mark it RTBC because I am not Views maintainer... will ping someone in IRC to give it a final review.
Comment #5
dawehnerThe fix looks perfect.
Comment #6
damiankloip commentedYep, looks good to me too.
Comment #7
tim.plunkett3x +1
Comment #8
alexpottCommitted 77b6167 and pushed to 8.x. Thanks!
Comment #9
damiankloip commentedHere is a D7 port of that.
Comment #10
dawehnercommitted and pushed
Comment #13
olli commentedThis gives me a notice "Undefined property: view::$changed in views_ui_ajax_form() (line 2967 of sites/all/modules/views/includes/admin.inc)" when clicking "Cancel".
Comment #15
damiankloip commentedGood catch, committed!