There was a recent change to the submission table where the left-hand column now shows the serial number rather than the submission id. That's a good change, but it broke webform_civicrm's theme tweaks. To take some of the voodoo out of altering that table, here is a simple patch to provide sid and serial numbers for each row, making it available to both php hooks and javascript on the client-side.

CommentFileSizeAuthor
submission_table.patch650 bytescolemanw

Comments

colemanw’s picture

colemanw commented
Issue summary: View changes
danchadwick’s picture

danchadwick commented

These reports are slated to be converted to views, which will re-break your theme. I'd suggest effort be put into that rather than invent more API, no?

colemanw’s picture

colemanw commented

In which version of webform will they be converted to views? My patch is for 4.x, not really thinking ahead to 5.x or D8, I suppose I'll cross those bridges when we get to them.

danchadwick’s picture

danchadwick commented

I'm not sure which version will have views. Patches welcome. ;)

colemanw’s picture

colemanw commented
Status: Needs review » Closed (won't fix)

Ok seems like "won't fix" is a reasonable answer for this one. I was able to hack around the problem and the converison to views will re-break it whether this patch goes into webform or not.

danchadwick’s picture

danchadwick commented

If you write a patch converting the Results page to use Views, you could control when your hack breaks. Just sayin'. :)