Right now it type hints to the class in multiple forms and controllers. It should type hint on the interface instead.

This currently breaks https://www.drupal.org/project/webprofiler

Patch coming up in a minute.

CommentFileSizeAuthor
#3 composer_manager-interface-2304103-3.patch1003 bytesberdir
#1 composer_manager-interface-2304103-1.patch4.96 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new composer_manager-interface-2304103-1.patch4.96 KB
cpliakas’s picture

cpliakas commented
Status: Needs review » Needs work

Thanks for the contribution! Looks like the patch no longer applies to HEAD, would you ming re-rolling?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new composer_manager-interface-2304103-3.patch1003 bytes

Yeah, looks like most were already fixed, just once instance wasn't updated.

cpliakas’s picture

cpliakas commented
Status: Needs review » Reviewed & tested by the community

Thanks for re-rolling and fixing the remaining one!

  • cpliakas committed e152405 on 8.x-1.x authored by Berdir 
    Issue #2304103 by Berdir: Fixed type hint on ConfigFactoryInterface.
cpliakas’s picture

cpliakas commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.