At some point, the entitycache module added support for entity languages. Based on the patch committed in #1073270: Webform needs to flush Entity Cache after updating components (and e-mail configurations), webform will clear the entity cache when emails are added/edited/deleted, but is calling cache_clear_all() directly instead of using the entity controller, which means that it will not clear the language-specific caches for the entity.

Instead, webform should call entity_get_controller('node')->resetCache(array($nid)) and let entitycache handle the actual clearing logic.

Patch applied against the 7.x.3.x branch. Thanks!

CommentFileSizeAuthor
#5 webform_email_entitycache_langcode-2303607-5.patch1.96 KBtheunraveler
webform_email_entitycache_langcode.patch958 bytestheunraveler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

theunraveler’s picture

theunraveler CreditAttribution: theunraveler commented
Related issues: +#1073270: Webform needs to flush Entity Cache after updating components (and e-mail configurations)
DanChadwick’s picture

DanChadwick CreditAttribution: DanChadwick commented
Version: 7.x-3.x-dev » 7.x-4.x-dev

I believe this patch should be applied against the currently-active branches, 7.x-4.x and 8.x. I don't use this module, so I have to take it on face value that the patch is correct.

DanChadwick’s picture

DanChadwick CreditAttribution: DanChadwick commented

@theunraveler -- Looking at 7.x-4.x, I see additional places where perhaps this change needs to be made. Can you supply a patch against the current dev?

theunraveler’s picture

theunraveler CreditAttribution: theunraveler commented
Assigned: Unassigned » theunraveler
theunraveler’s picture

theunraveler CreditAttribution: theunraveler commented
Assigned: theunraveler » Unassigned
Status: Active » Needs review
FileSize
webform_email_entitycache_langcode-2303607-5.patch1.96 KB

OK, here's a new patch against the 7.x-4.x branch that address all places in the codebase where cache_clear_all() is used to clear node entity caches.

DanChadwick’s picture

DanChadwick CreditAttribution: DanChadwick commented
Status: Needs review » Fixed

Thank you very much. #5 committed to 7.x-4.x and 8.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

torotil’s picture

torotil CreditAttribution: torotil commented

I've cherry-picked this into 7.x-3.x and it will be part of the 7.x-3.23 release.