CommentTypeForm allows the entity type to be changed

Yep should be removed if entity isn't new, patch coming

Hoping for Red/Green

1. +++ b/core/modules/comment/src/CommentTypeForm.php
   @@ -87,18 +87,31 @@ public function form(array $form, array &$form_state) {
   +      $form['target_entity_type_id'] = array(
   +        '#type' => 'value',
   +        '#value' => $comment_type->getTargetEntityTypeId(),
   +      );
   

   Is this really necessary?

   The entity building should be intelligent enough to only update existing values, but I only know for sure that's true for content entities.

2. +++ b/core/modules/comment/src/Tests/CommentTypeTest.php
   @@ -76,6 +76,11 @@ public function testCommentTypeCreation() {
   +    // Edit the comment-type and attempt to change the entity-type.
   +    $this->drupalGet('admin/structure/comment/manage/foo');
   +    // The entity-type should not be editable on an existing comment-type.
   +    $this->assertNoField('target_entity_type_id', 'Entity type file not present');
   

   The first comment seems a bit strange, we're not really attempting to change it, as there's no way to do it (with the fix).

   I think it should just say that we verify that it can not be changed and is a read-only information? The second comment is enough IMHO for both lines of code. Possibly add an assertion for the label?

Fixes 4

Thanks, no need to hold this up further.

Something like this ?

Thanks

Committed and pushed to 8.x. Thanks!