#2302167-3: Pass on queue name to event illustrates how severely limited the hook system is. As a solution, we can remove all hooks completely and rely on events instead. The event infrastructure and implementations are already in place, so this issue would only require the removal of code.

CommentFileSizeAuthor
#5 payment_2302651_5.patch59.7 KBxano
#5 interdiff.txt1.74 KBxano
#3 payment_2302651_3.patch59.19 KBxano
#3 interdiff.txt853 bytesxano
#1 payment_2302651_1.patch59.2 KBxano

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Active » Needs review
StatusFileSize
new payment_2302651_1.patch59.2 KB

Status: Needs review » Needs work

The last submitted patch, 1: payment_2302651_1.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt853 bytes
new payment_2302651_3.patch59.19 KB

Status: Needs review » Needs work

The last submitted patch, 3: payment_2302651_3.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.74 KB
new payment_2302651_5.patch59.7 KB

Status: Needs review » Needs work

The last submitted patch, 5: payment_2302651_5.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Fixed

  • Xano committed ad3882f on 8.x-2.x 
    Issue #2302651 by Xano: Remove all hooks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.