To reproduce: Create a product like "Snickers Bar" or "Bottle of Water" as listed below.

screenshot

Open POS view and tap "Product" to see the table of available products. Tap "Add to Order". For "Snickers Bar" and "Bottle of Water" in my product list, the modal closes and I get the error message "Invalid input." For the other two products, the product is added to the order correctly.

This is probably because of a leading zero in the SKU.

CommentFileSizeAuthor
#7 invalid_input_adding-2301183-7.patch1.2 KBmglaman
#4 invalid_input_adding-2301183-4.patch809 bytesicylace
Screen Shot 2014-07-10 at 2.35.23 PM.png32.33 KBjbeuckm

Comments

jbeuckm’s picture

jbeuckm commented
Issue summary: View changes
jbeuckm’s picture

jbeuckm commented
Issue summary: View changes
jbeuckm’s picture

jbeuckm commented
Title: "Invalid Input" adding some products. » "Invalid Input" Adding SKU with Leading Zero
icylace’s picture

icylace commented
Status: Active » Needs review
StatusFileSize
new invalid_input_adding-2301183-4.patch809 bytes

jQuery's data() will try to convert data attribute values into JavaScript values. attr() won't try to do any conversion and is what we need to handle leading-zero SKUs correctly.

zeezhao’s picture

zeezhao commented

Thanks for your patch. It works but appears to have adverse effect on product quantity. When you press product button on POS and change quantity before "Add to Order", quantity on POS always comes up as 1 after pressing "Add to order".

You may need to clear your cache to see that prior to patch this worked fine.

rbayliss’s picture

rbayliss commented

Yeah, it's unfortunate we can't just use .data() for this, but I don't see any way but to go with .attr(). Need this patch rerolled to have the quantity change handler update the quantity using .attr() too.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new invalid_input_adding-2301183-7.patch1.2 KB

Updated patch per #6

kfitz’s picture

kfitz commented

Patch addresses and corrects issue; tested on fresh install.

kfitz’s picture

kfitz commented
Status: Needs review » Reviewed & tested by the community
kfitz’s picture

kfitz commented
smccabe’s picture

smccabe commented
Status: Reviewed & tested by the community » Fixed

  • smccabe committed 8259847 on 7.x-1.x authored by mglaman 
    Issue #2301183 by mglaman, icylace: "Invalid Input" Adding SKU with...
smccabe’s picture

smccabe commented
Status: Fixed » Closed (fixed)