I've started work on a Drupal 8 port of this.

so far it's just basic subscribe to lists functionality.

Code to come.

Could you create an 8.x-1.x-dev version for this issue to be assigned to?

Comments

thtas’s picture

thtas commented
Issue summary: View changes
thtas’s picture

thtas commented

I've added the files to github

https://github.com/thtas/campaignmonitor

Notes:

- Does not contain the submodules campaignmonitor_registration and campaignmonitor_user
- The bulk of the work here as converting campaignmonitor wrapper class to use drupal 8 functions and also porting over the admin settings form.

jeremylichtman’s picture

jeremylichtman commented

We've created a pull request on this github repo to update the D8 version of the module to current Drupal 8 specifications.

See: https://github.com/thtas/campaignmonitor/pull/2

Perhaps the module devs can look into creating a D8 branch of this module on Drupal.org?

thtas’s picture

thtas commented

Thanks for your work on this. looks good!

mpp’s picture

mpp commented
Priority: Normal » Major

Would be nice to have an 8.x branch here.

Some issues with the github branch:
- documentation link (now a 404) should point to https://www.campaignmonitor.com/api/getting-started/#clientid
- Library path points to the README file for installing the library dependencies but there is nothing about where to find the library yet. "The Campaign Monitor PHP integration library was not detected, please see the README for information about installing the library." We should probably add/rewrite the README.txt from the D7 version.
- The textformat seems to be required when saving the settings form but its setting is not stored upon saving.
- There's no validation/warning when entering a wrong API key

NewZeal’s picture

NewZeal commented
Status: Needs work » Fixed

Unfortunately, I did not see this ticket before I started creating a D8 version. Anyway, new module created using D7 code for upgrade. Marking this as fixed so that issues can be posted against the D8 version.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.