I can't enable the module without breaking my installation. Doing it through the Drupal admin results in a broken site with a generic error The website encountered an unexpected error. Please try again later..

I disabled through drush, and tried again, and this is the error I see.

WD php: PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown   [error]
column 'oasp.data' in 'field list': SELECT oasp.position_id AS
position_id, oasp.name AS name, oasp.description AS description,
oasp.data AS data
FROM
{openadstream_positions} oasp
ORDER BY oasp.name ASC; Array
(
)
 in _openadstream_positions() (line 35 of /Users/chris/Sites/test/sites/all/modules/2296585/openadstream.module).
Cannot modify header information - headers already sent by (output      [warning]
started at /usr/local/Cellar/drush/6.3.0/libexec/includes/output.inc:38)
bootstrap.inc:1217
PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'oasp.data' in 'field list': SELECT oasp.position_id AS position_id, oasp.name AS name, oasp.description AS description, oasp.data AS data
FROM
{openadstream_positions} oasp
ORDER BY oasp.name ASC; Array
(
)
 in _openadstream_positions() (line 35 of /Users/chris/Sites/test/sites/all/modules/2296585/openadstream.module).
Drush command terminated abnormally due to an unrecoverable error.

Comments

natemow’s picture

Assigned: Unassigned » kylejbertelsen
Status: Active » Needs work

Need to review hook_install for correct schema setup.

natemow’s picture

Assigned: kylejbertelsen » Unassigned
Priority: Critical » Normal
Status: Needs work » Postponed (maintainer needs more info)
StatusFileSize
new42.69 KB

Chris -- I just disabled and uninstalled, then re-installed the mod locally and didn't have any issues; see attached.

Curious if you tested this on a vanilla D7 site, or on a site that was running the old version that came off of GitHub? If the latter, you should reinstall that version, overwrite the files with the contents of this project repo, then just run update.php; openadstream_update_7103() will add the openadstream_positions.data column if it doesn't already exist.

freshyill’s picture

StatusFileSize
new51.44 KB
new200.25 KB

Got it working on a clean D7 install. Functionality is all there and seems to be working mostly fine from a user standpoint, but with a few Drupal-facing issues.

* Got some post-install errors, possibly because no positions are defined yet at this point?

* That third error logged quite a few times after installing as well, possibly due to configuration on my end (screenshot attached).

* Under DX ad tag scheme, width and height values are required. I suggest making these fields required (at least for DX). Current functionality allows saving and creating the associated block, but doesn't throw any errors (even in javascript console). It just writes empty markup to the page with no ad call.

freshyill’s picture

Seems to be working just fine now in an existing installation. No errors logged, but there is the issue of ads not displaying unless dimensions are added when switching to DX tags.

natemow’s picture

Status: Postponed (maintainer needs more info) » Needs work
damienmckenna’s picture

Project: » Open AdStream
Version: » 7.x-3.x-dev

Moving the issue to the primary project.

damienmckenna’s picture

natemow’s picture

StatusFileSize
new7.39 KB

Patch attached per issues identified in #2299867-3: Enabling module breaks site.

natemow’s picture

Assigned: Unassigned » natemow
Status: Needs work » Needs review
natemow’s picture

Just checking in here -- can we get the patches applied (or ideally) get VCS write perms for the project? Would love to get this stuff closed out. Thanks!

damienmckenna’s picture

Status: Needs review » Reviewed & tested by the community

This looks good.

damienmckenna’s picture

@natemow: You're a comaintainer now, have at it! (also, sorry for the delay)

natemow’s picture

Status: Reviewed & tested by the community » Fixed
natemow’s picture

Status: Fixed » Closed (fixed)