There are several topics that are currently in other files that should be in core/modules/system/core.api.php, and a few in core.api.php that should be moved to other files.
So, the task here is to make a patch that moves them.
The topics to be moved into core.api.php are:
1) https://api.drupal.org/api/drupal/core%21includes%21module.inc/group/cal... (in core/includes/module.inc)
2) https://api.drupal.org/api/drupal/core%21includes%21module.inc/group/hoo... (in core/includes/module.inc)
3) https://api.drupal.org/api/drupal/core%21includes%21form.inc/group/form_... (in core/includes/form.inc)
4) https://api.drupal.org/api/drupal/core!includes!common.inc/group/queue/8 (in core/includes/common.inc)
The topics to be moved out of core.api.php are:
5) https://api.drupal.org/api/drupal/core%21modules%21system%21core.api.php... - should be in core/modules/system/entity.api.php
6) https://api.drupal.org/api/drupal/core%21modules%21system%21core.api.php... - should be in core/modules/system/language.api.php
7) https://api.drupal.org/api/drupal/core%21modules%21system%21core.api.php... - should be in core/modules/system/theme.api.php
Note: The patch for this issue should not be done until #2216535: Replace Node overview topic and Node API topic with Entity Hooks topic is committed
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | move-topics-core-api-php-2299679-6.patch | 70.86 KB | l0ke |
| #4 | drupal-Move_some_topics_to_or_from_core.api_.php-2299679-04.patch | 71.62 KB | jmmarquez |
Comments
Comment #1
jhodgdonAdded one more and numbered them.
Comment #2
jhodgdonThe "node overview topic" patch has been committed. This one can be done now. Thanks!
Comment #3
jmmarquez commentedI start with this.
Comment #4
jmmarquez commentedUploading patch.
Comment #6
l0keUpdate the patch.
Comment #7
jhodgdonPatch looks good, thanks!
Can you confirm that you started over from an updated/pulled Drupal Core repository and made the patch by using copy/paste on what was there (didn't start from the previous patch)? Because I really don't want to go through the patch line by line and verify that the out vs. in lines are the same. :)
Comment #8
l0keThanks!
Yes, patch based on the current 8.x HEAD and made from scratch by copy/paste corresponding parts.
Comment #9
jhodgdonPerfect! We can't commit this patch today until the 8.x to 8.0.x changeover is complete, but we'll get it in shortly.
Comment #10
jhodgdonThanks again! Committed to 8.0.x.
Comment #13
m1r1k commented