As per #2272279: Kill RenderWrapper class twig variable {{ page }} should be now {{ page.content }} or Twig engine throws an Twig_Error_Runtime-error.

CommentFileSizeAuthor
#6 2299469-6.patch382 byteskarishmaamin
#5 Screenshot_14.png31.53 KBBmuskan
#2 2299469-twig-variable-page-changed-to-page-content-2.patch1.08 KBrpsu
#1 2299469-twig-variable-page-changed-to-page-content-1.patch326 bytesrpsu

Comments

rpsu’s picture

rpsu
he/him
Primary language Finnish
commented
Status: Active » Needs review
StatusFileSize
new 2299469-twig-variable-page-changed-to-page-content-1.patch326 bytes

Patch solves the issue.

rpsu’s picture

rpsu
he/him
Primary language Finnish
commented
StatusFileSize
new 2299469-twig-variable-page-changed-to-page-content-2.patch1.08 KB

Better patch, covers all changes in #2272279: Kill RenderWrapper class

  1. {{ head }} -> {{ page.head }}
  2. {{ scripts }} -> {{ page.scripts }}
  3. {{ styles }} -> {{ page.styles }}
  4. footer-scripts in {{ page.scripts('footer') }}
eporama’s picture

eporama commented
Status: Needs review » Reviewed & tested by the community

This patch in #2 worked as expected, no more exceptions. Following the thread in #2272279: Kill RenderWrapper class, it appears that this is all that is needed, so marking as RTBC.

gauravvvv’s picture

gauravvvv commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll 
error: patch failed: templates/html.html.twig:1
error: templates/html.html.twig: patch does not apply
Checking patch zircon.theme...
error: while searching for:
<?php
use Drupal\Component\Utility\Xss;
use Drupal\Core\Template\RenderWrapper;
use Drupal\Core\Template\Attribute;

function zircon_preprocess_page(&$variables) {

error: patch failed: zircon.theme:1
error: zircon.theme: patch does not apply

Patch is not applying any more in D8

Bmuskan’s picture

Bmuskan commented
StatusFileSize
new Screenshot_14.png31.53 KB

Replace 17th line of code {{ page }} to {{ page.content }} in html.html.twig file as given in screenshot:

karishmaamin’s picture

karishmaamin commented
Status: Needs work » Needs review
StatusFileSize
new 2299469-6.patch382 bytes

Re-rolled patch Drupal 8

  • Gauravmahlawat authored caf52d7 on 9.1.x 
    Issue #2299469 by rpsu, karishmaamin, Bmuskan, Gauravmahlawat: Twig...
gauravvvv’s picture

gauravvvv commented

This has been committed to 8.x-2.x and 9.1.x-dev.

New version 9.1.x-dev is released for Drupal 9 support and contains UI bug fixes.
Thank you for working on this.

gauravvvv’s picture

gauravvvv commented
Status: Needs review » Fixed
Issue tags: -Needs reroll

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.