Remove the function drupal_build_form() once all its usage is removed in favour of \Drupal::formBuilder()->buildForm() as it is deprecated and wil no longer be used.

To remove all usages, here https://www.drupal.org/node/2299421

patch is submitted for same.

Suggested commit message (as of #11): Issue #2299427 by amitgoyal, tim.plunkett: Remove drupal_build_form() once all its usage is removed as it is deprecated.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joshi.rohit100’s picture

Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, remove-drupal-build-form.patch, failed testing.

ParisLiakos’s picture

Issue tags: -@depreacted +@deprecated
amitgoyal’s picture

Status: Needs work » Needs review
FileSize
668 bytes

The patch "remove-drupal-build-form_0.patch" no longer applies in the latest repo.

Please review revised patch attached.

Status: Needs review » Needs work

The last submitted patch, 4: remove-drupal-build-form-2299427-4.patch, failed testing.

joshi.rohit100’s picture

Status: Needs work » Needs review

The last submitted patch, remove-drupal-build-form.patch, failed testing.

ianthomas_uk’s picture

Status: Needs review » Closed (duplicate)

Duplicate of #2300581: Remove drupal_build_form(), which has an older and more comprehensive patch, and it listed in the relevant meta (#2205673: [META] Remove all @deprecated functions marked "remove before 8.0")

ianthomas_uk’s picture

Issue summary: View changes
Status: Closed (duplicate) » Reviewed & tested by the community

... but that patch doesn't apply, because half of it was applied in the sister issue to this one.

#4 is good and is covered by change record https://www.drupal.org/node/2121003

Suggested commit message: Issue #2299427 by amitgoyal, tim.plunkett: Remove drupal_build_form() once all its usage is removed as it is deprecated.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: remove-drupal-build-form-2299427-4.patch, failed testing.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: remove-drupal-build-form-2299427-4.patch, failed testing.

Status: Needs work » Needs review
ianthomas_uk’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Can we add this issue to the relevant change record please. Thanks.

ianthomas_uk’s picture

Status: Needs work » Reviewed & tested by the community

Sorry, now done.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 527e690 and pushed to 8.x. Thanks!

  • alexpott committed 447cfbf on 8.x
    Issue #2299427 by tim.plunkett, amitgoyal, joshi.rohit100: Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.