Remove the usage of drupal_build_form() as it is deprecated and replaced with \Drupal\Core\Form\FormBuilderInterface::buildForm().

once all usage is removed, method is removed here https://www.drupal.org/node/2299427

Submit the patch for same.

CommentFileSizeAuthor
#3 interdiff-2299421-0-3.txt486 bytesamitgoyal
#3 remove-drupal-build-form-2299421-3.patch1.93 KBamitgoyal
remove-drupal-build-form.patch1.93 KBjoshi.rohit100

Comments

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Issue summary: View changes
ParisLiakos’s picture

ParisLiakos commented 
+++ b/core/modules/views/includes/ajax.inc
@@ -10,7 +10,8 @@
+ * Wrapper around \Drupal\Core\Form\FormBuilderInterface::buildForm() to handle ¶

super nitpicky: plz remove trailing space

amitgoyal’s picture

amitgoyal commented
StatusFileSize
new remove-drupal-build-form-2299421-3.patch1.93 KB
new interdiff-2299421-0-3.txt486 bytes

Please review revised patch as per fixes in #2.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

thank you!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Can we add this issue to the relevant change notice.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Needs work » Needs review

Added to relevent change notice https://www.drupal.org/node/2121003

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 573ad2a and pushed to 8.x. Thanks!

  • alexpott committed 573ad2a on 8.x 
    Issue #2299421 by amitgoyal, joshi.rohit100: Remove all usage of...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.