Bartik's field--taxonomy-term-reference.html.twig doesn't output content_attributes, has out-of-date documentation

Ok, I'll try to patch this.

Okay, here's a patch.

Let's see what Testbot thinks...

I am aware of two problems though:

1. after the patch is applied, the label is a much smaller font-size than it was before, and,
2. I forgot to update the docblock at the top of the twig file.

after the patch is applied, the label is a much smaller font-size than it was before, and,

Whoops, this is not true — I'd reloaded the page while in the middle of writing the patch, so I'd seen the label without the field-label class on it.

I forgot to update the docblock at the top of the twig file.

Fixed in attached patch.

Comparing core/modules/system/templates/field.html.twig to core/themes/bartik/templates/field--taxonomy-term-reference.html.twig and comparing template_preprocess_field() to bartik_preprocess_field() reveals the display logic has diverged somewhat...

1. In the documentation for field--taxonomy-term-reference.html.twig, some of the documentation has been improved:
   

   - * - label_hidden: Whether to show the field label or not.
   + * - label_hidden: Whether the field label has been set to hidden.
   - * - item_attributes: List of HTML attributes for each item.
   + * - item_attributes: HTML attributes for each item.
   - * @ingroup themeable
   

2. In the code that outputs field items, the wrapper is missing the field-items class and any content attributes (e.g.: RDF):
   

   -  <div class="field-items"{{ content_attributes }}>
   +  <ul class="links">
   

... I think it's worth expanding the scope of this issue a bit to include those.

Here's a patch that includes the changes suggested in #5.

#2227601: [Follow-up] Add a "Visually-hidden" field label formatter did part of the original scope of this issue. #2301599: Regression: Bartik's field--taxonomy-term-reference.html.twig doesn't properly output label attributes should fix the twig file.

Updating the scope of this issue accordingly.

Fixing title too.

Here's a patch.

The only difference is that I'm not changing label_attributes to title_attributes because that's done in #2301599: Regression: Bartik's field--taxonomy-term-reference.html.twig doesn't properly output label attributes.

I changed label_attributes -> title_attributes in #2301599 (oops!) :)

Actually, that's not an Oops because field.tpl.php uses title_attributes too — yay for new-found consistency between Bartik and Core! :D

Here you go...

Whoops, fail, I attached the old patch I was supposed to re-roll.