After installing the Message Alter module, with every page an warning is displayed:

"Strict warning: Only variables should be passed by reference in theme_messages_alter_settings_page() (Line 163 of /.../sites/all/modules/csm/messages_alter/messages_alter.module)."

Lines 163 and 164 are affected.
This bug could be related to issue 730272, So maybe it is the same, but not fixed already. I don't think this is a php config issue, as all other modules (50+) work perfectly without this error here.
I use apache & php5.4;

CommentFileSizeAuthor
#1 strict-warning-2298549.patch701 bytesstefank

Comments

stefank’s picture

stefank commented
StatusFileSize
new strict-warning-2298549.patch701 bytes

Hi @droetker,

Can you test it with the patch and see if that is going to fix it.

Thanks

stefank’s picture

stefank commented
Status: Active » Needs review
jim0203’s picture

jim0203 commented
Status: Needs review » Postponed (maintainer needs more info)

That patch looks fine to me, but I'm struggling to recreate the issue on my dev environment. @stefank, can you see the E_STRICT error? @droetker, are you able to reproduce from a vanilla D7 installation and let me know how?

Also, running php -d error_reporting=4095 -l messages_alter.module (as per http://php.net/manual/en/migration51.errorcheck.php) doesn't seem to throw up any errors.

As far as I can see this isn't related to #730272: Warning Message "pass-by-reference has been deprecated".

stefank’s picture

stefank commented

James, not getting any errors. Just to be sure, I checked my php.ini file and got error_reporting = E_ALL. I haven't reproduced the error, but though it might be something related to render drupal forms.

jim0203’s picture

jim0203 commented

Thanks @stefank, I'll leave this as Postponed, then. FYI E_ALL doesn't always include E_STRICT (bizarrely): http://stackoverflow.com/a/74923

stefank’s picture

stefank commented

Good to know, but using PHP 5.4.10 so should be covered by that.

stefank’s picture

stefank commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

Closing issue due to lack of activity.