Remove all PNG fallbacks for SVG

While modernizr was updated in the process, the diff only contains svg test change no other modernizr-related code was changed.

73 files changed, 7 insertions(+), 404 deletions(-)

GO!

We've still got rules that refer to .no-svg in toolbar.icons.css

The patch removes .no-svg leftovers that @alexpott mentioned in his comment #4

Committed 9e4300f and pushed to 8.x. Thanks!

Well, some of those PNGs were still being used.

YOLO indeed.

Here's the one I hit.

core/modules/simpletest/src/Form/SimpletestResultsForm.php:68:      '#uri' => 'core/misc/icons/ea2800/error.png',
core/modules/update/update.report.inc:64:        $uri = 'core/misc/icons/ea2800/error.png';

$ grep -nr "core/misc/icons.*png" core
core/modules/simpletest/src/Form/SimpletestResultsForm.php:61:      '#uri' => 'core/misc/icons/73b355/check.png',
core/modules/simpletest/src/Form/SimpletestResultsForm.php:68:      '#uri' => 'core/misc/icons/ea2800/error.png',
core/modules/simpletest/src/Form/SimpletestResultsForm.php:75:      '#uri' => 'core/misc/icons/e29700/warning.png',
core/modules/simpletest/src/Form/SimpletestResultsForm.php:82:      '#uri' => 'core/misc/icons/e29700/warning.png',
core/modules/simpletest/src/Tests/SimpleTestTest.php:351:          $ok_url = file_create_url('core/misc/icons/73b355/check.png');
core/modules/update/update.report.inc:50:        $uri = 'core/misc/icons/73b355/check.png';
core/modules/update/update.report.inc:57:        $uri = 'core/misc/icons/e29700/warning.png';
core/modules/update/update.report.inc:64:        $uri = 'core/misc/icons/ea2800/error.png';
core/modules/update/update.report.inc:71:        $uri = 'core/misc/icons/e29700/warning.png';

I assumed all these lined need a change to *.svg? Don't know how to review this patch?

I think this is worth writing a quick test for.
Both the simpletest results page as well as the update status report are visually broken in HEAD.

I'd like to help here. @tim "A quick test" being a file_exists() for each expected system image, or what?

I'm seeing this also, but not sure a test makes sense unless it's somehow to scan all the admin pages and look for images that are 404

That would be a more useful generic test.

I was just thinking of a test for the status report page.

@tim.plunkett - checking IMG tags for 404s? If we are going to write a test, it should be non-fragile.

@LewisNyman - hmm, actually I think they are on the status page, but IMG tags for simpletest it seems.

Not sure how best to test CSS files for image 404s

Based on the fact that we cant currently test for visual changes from css, and in the interest of getting head un-broken, could #12 be committed, and then a follow-up issue be created to refactor the hardcoded images in simpletest into CSS similar to the status report page. With the status icons built in a consistent way through CSS, the visual regression testing discussion will be made easier.

Decided to reroll the patch..

Rerolled the patch against wrong branch. Remember to change your branch to 8.0.x :)

created #2322551: Simpletest module referrring to wrong icon location (.png instead of .svg) and looks like related this issue.

Rerolled the patch against wrong branch. Remember to change your branch to 8.0.x :)

ref: https://twitter.com/alexpott/status/499064691193151488

Looks good. +1 for RTBC.

Committed 0aaa1c8 and pushed to 8.0.x. Thanks!