We need to get layout plugin type from somewhere, which can be used by our PanelsDisplayVariant class.

I see three possible options:

  • Implement a layout plugin type in Panels. This might be a good temporary solution, so that we can move forward and have something that seems Panels-y.
  • Get the layout plugin type into Drupal core. I don't know the core teams feelings about this, but here is an issue to discuss it: #2296423: Implement layout plugin type in core
  • Depend on a 3rd party module that declares one. frega has refactored just the plugin part of his 'layout' module on GitHub into a sandbox on Drupal.org called 'layout_plugin'.

Since we need layouts to move forward on the D8 port, we may end up choosing two options: one temporary solution for now, and another for the long-term.

Sandbox branch

http://cgit.drupalcode.org/sandbox-dsnopek-2290237/log/?h=layouts-2296431

CommentFileSizeAuthor
#8 panels-layout-plugin-2296431-8.patch11.63 KBdsnopek
#7 panels-layout-plugin-2296431-7.patch11.45 KBdsnopek
#6 panels-layout-plugin-2296431-6.patch11.83 KBdsnopek
#5 panels-layout-plugin-2296431-5.patch7.78 KBdsnopek

Comments

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Parent issue: » #2169319: [meta] Drupal 8 port of Panels
Related issues: -#2169319: [meta] Drupal 8 port of Panels
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Issue summary: View changes
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

frega has refactored just the plugin part of his 'layout' module on GitHub into a sandbox on Drupal.org. I think this is the way to go for now!

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Issue summary: View changes

I've started working on this in the 'layouts-2296431' branch on the 'd8panels' sandbox:

http://cgit.drupalcode.org/sandbox-dsnopek-2290237/log/?h=layouts-2296431

The admin forms are all working, but I'm getting an error when trying to render the page. Strangely, nothing is appearing in my error log. :-/

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Needs work
StatusFileSize
new panels-layout-plugin-2296431-5.patch7.78 KB

Here is the first sort of working patch to use the layout_plugin module to provide layouts.

However, it's blocked by a couple of issues in layout_plugin:

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
StatusFileSize
new panels-layout-plugin-2296431-6.patch11.83 KB

Here's a new version of the patch!

Updates include:

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs work » Needs review
StatusFileSize
new panels-layout-plugin-2296431-7.patch11.45 KB

Removed some left over cruft from a previous approach.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
StatusFileSize
new panels-layout-plugin-2296431-8.patch11.63 KB

Chasing HEAD!

  • japerry committed 36981ed on 8.x-3.x authored by dsnopek 
    Issue #2296431 by dsnopek: Implement layout plugin type for panels d8
japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Fixed

Looks good for a first run! If we need to keep making updates to keep up with core, lets keep it here. Otherwise if there are new issues, make a separate issue for it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.