Iran has a new Province called "Alborz" since a few years ago.
It should be added to Iran's cif file.

CommentFileSizeAuthor
#4 ubercart-add_Alborz_province-2294773-4.patch5.73 KBhejazee
#3 ubercart-add_Alborz_province-3.patch1.1 KBhejazee
#1 ubercart-add_Alborz_province-1.patch1.13 KBhejazee
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hejazee’s picture

hejazee CreditAttribution: hejazee commented
Status: Active » Needs review
FileSize
ubercart-add_Alborz_province-1.patch1.13 KB

This is my patch.

Status: Needs review » Needs work

The last submitted patch, 1: ubercart-add_Alborz_province-1.patch, failed testing.

hejazee’s picture

hejazee CreditAttribution: hejazee commented
Status: Needs work » Needs review
FileSize
ubercart-add_Alborz_province-3.patch1.1 KB

I hope this one will work.

hejazee’s picture

hejazee CreditAttribution: hejazee commented
FileSize
ubercart-add_Alborz_province-2294773-4.patch5.73 KB

The CIF file should be renamed for ubercart to be informed about the update.

hejazee’s picture

hejazee CreditAttribution: hejazee commented
Title: Update country information file for Iran » Update country information file for Iran: Add the Alborz province
Priority: Critical » Major
Status: Needs review » Patch (to be ported)

I think this patch is ready to be ported. (tested on my site)

  • TR committed 9395dbc on 7.x-3.x authored by hejazee 
    Issue #2294773 by hejazee: New CIF file for Iran, with added province.
TR’s picture

TR CreditAttribution: TR commented
Priority: Major » Normal
Status: Patch (to be ported) » Fixed

Thanks! Patch looks good. There was one line with extra whitespace which I removed but the important parts were there, especially the update() function which people usually forget.

I committed the change.

  • TR committed 5b52b6d on 6.x-2.x authored by hejazee 
    Issue #2294773 by hejazee: New CIF file for Iran, with added province.

  • TR committed e323eb8 on 8.x-4.x authored by hejazee 
    Issue #2294773 by hejazee: New CIF file for Iran, with added province.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.