Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
If you try to provide a config entity type from within Drupal\Core, the resulting config name is Core.$type.$id.yml, and it should be lowercase.
Proposed resolution
Change the places core uses Core, and switch to core.
Remaining tasks
Pull fixes for this out of #2283977: Create a new ConfigEntity type for storing bundle-specific customizations of base fields
User interface changes
API changes
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 2294177.1.patch | 6.29 KB | alexpott |
Comments
Comment #1
alexpottThis ain't really possible to test unless we convert an existing config entity. In many ways action, date format and menu should be in core and not system but that is one heck of a change in terms of config object name change (all existing site would break).
So if we do want to split this off from #2283977: Create a new ConfigEntity type for storing bundle-specific customizations of base fields then this will have to be another beta blocker too. Since this blocks that. Here's the patch if we want to go ahead.
Comment #2
yched CreditAttribution: yched commentedOther candidates would be entity view/form displays ?
Comment #3
xjmComment #4
xjmAn advantage of moving something provided by the entity module is that it also unblocks the issue to de-module-ify entity again.
Comment #5
tim.plunkettThe other thing we have not resolved it how to deal with things like
admin_permission = "administer display modes",If the UI code is to be moved into field_ui.module and entity.module will be deleted, does that mean that system_permission would have to provide this?
Comment #6
effulgentsia CreditAttribution: effulgentsia commentedComment #7
xjmBased on the discussions in #2295469: Add support for static permission definitions with *.permissions.yml and #2088371: YAML discovery incompatible with translations I'd recommend looking into
system_permission()for now, though Gábor also indicated one-off translation for YAYAML (Yet Another YAML) wouldn't be much worse than anything else. Buthook_permission()does just work. It's ugly and non-ideal, but it could be fixed in a followup or not.Comment #9
Gábor HojtsyI think system_permission() is totally fine. I guess in this case we are not adding tests because we'll do in #2283977: Create a new ConfigEntity type for storing bundle-specific customizations of base fields soon and otherwise not possible here?
Comment #10
alexpottYeah we can't add a specific test for this unfortunately. But the moment it is use it is tested :)
Comment #11
Gábor HojtsyAll righto, looks good to me. The entity module demodulifying will have to deal with the permission then (in #2031717: Make entity module not required) as far as I understand so this one is good.
Comment #12
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks. It's a bit of a hack but I think we can make an exception to allow for the beta blockers to make progress.
Comment #15
cilefen CreditAttribution: cilefen as a volunteer commented