Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 Jun 2014 at 20:20 UTC
Updated:
25 Aug 2017 at 22:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
ParisLiakos commentedComment #2
ParisLiakos commentedComment #4
ParisLiakos commented-.-
Comment #5
sunAwesome.
Comment #6
alexpottCommitted 8074550 and pushed to 8.x. Thanks!
Comment #8
chx commentedThat was great... except now we can't implement phpdbg support in drupal_is_cli() because there's no API function to fix.
Comment #9
chx commentedalexpott asked for clarification. phpdbg is a php debugger that has been included in PHP 5.6. https://wiki.php.net/rfc/phpdbg
the way to support it is
PHP_SAPI === 'cli' || PHP_SAPI === 'phpdbg'but now there's no place to put this.Comment #10
ParisLiakos commentedi do not see why we should specialcase for phpdbg.
Did you try something on it and it didnt work?
If there is an issue with phpdbg support, and we need to add checks like that, then an issue should be opened, which adds a method to the
Enviromentcomponent.Keeping
drupal_is_cli()around just in case we might need it, is something i disagree withComment #11
chx commentedw/e
Comment #12
jbrown commentedThe change record is not correct - drupal_is_cli() hasn't been deprecated, it has been removed.
Comment #14
fubhy commentedSorry, but why exactly was this issue closed? It's impossible currently to run the Drupal testsuite with phpdbg. Checking just for 'cli' is simply wrong if we want to support phpdbg and I am pretty sure we want that.
Comment #15
cilefen commentedIt was closed for having met its goals at the time.
Comment #16
cilefen commentedPlus it's been closed so long, your follow up issue is fine.