CommentFileSizeAuthor
#2 interdiff.txt812 bytesbenjy
#2 2294083-2.patch6.83 KBbenjy
#1 drupal-2294083.patch6.03 KBParisLiakos
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Active » Needs review
FileSize
drupal-2294083.patch6.03 KB
benjy’s picture

benjy CreditAttribution: benjy commented
Status: Needs review » Reviewed & tested by the community
FileSize
2294083-2.patch6.83 KB
interdiff.txt812 bytes

Patch attach removes module_install() just as a sanity check that there isn't anything else using it.

Patch in #1 looks good, please don't credit me in the commit.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work

Can we acttach the relevant CR to the issue?

ParisLiakos’s picture

ParisLiakos CreditAttribution: ParisLiakos commented
Status: Needs work » Reviewed & tested by the community

sorry, missed that

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed patch in #1... 937be05 and pushed to 8.x. Thanks!

  • alexpott committed 937be05 on 8.x 
    Issue #2294083 by ParisLiakos: Remove usages of module_uninstall().

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.