Problem/Motivation

In locale module, in localsettingform, the old procedural t() function is used.

Proposed resolution

Change them to $this->t().

Remaining tasks

User interface changes

API changes

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task
Unfrozen changes Unfrozen because it only changes internal code to use the proper method for string translation
CommentFileSizeAuthor
#4 2293813-old-url-t-in-locale-4.patch4.64 KBjoshi.rohit100
#2 2293813-old-url-t-in-locale-2.patch5.38 KBpcambra
old-url-t-in-locale.patch5.35 KBjoshi.rohit100

Comments

dawehner queued old-url-t-in-locale.patch for re-testing.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
StatusFileSize
new 2293813-old-url-t-in-locale-2.patch5.38 KB

Here's a re-roll

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Patch no longer applies.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Needs work » Needs review
StatusFileSize
new 2293813-old-url-t-in-locale-4.patch4.64 KB

Rerolled the patch

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Title: Old t() and url() method in locale localsettingform » Replace t() function with class method call in locale localsettingform
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

This looks good to go.

I've added a beta phase evaluation to the issue summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Component: lock system » locale.module
Status: Reviewed & tested by the community » Fixed
Issue tags: +SprintWeekend2015

Committed efbeab2 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed efbeab2 on 8.0.x 
    Issue #2293813 by joshi.rohit100, pcambra: Replace t() function with...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.