Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up to #2262147: Various base test classes are not abstract
Various migrate_drupal PHPUnit base test classes are declared wrongly, because:
- The base test classes are not declared as abstract.
- The base test classes wrongly implement
getInfo()
. - The root test class
MigrateSqlSourceTestCase
implements atest*()
method, which turns the base classes into valid test classes.
Due to all issues combined, the error is not and cannot be caught by any of the existing test class validations.
Comment | File | Size | Author |
---|---|---|---|
#5 | test.migrate-drupal-base.5.patch | 6.45 KB | sun |
test.migrate-drupal-base.0.patch | 6.45 KB | sun | |
Comments
Comment #1
sunComment #2
sunComment #3
ParisLiakos CreditAttribution: ParisLiakos commentedComment #4
chx CreditAttribution: chx commented+ * Base class for taxomony term source unit tests
Comment #5
sunWhoops, thanks.
Comment #6
benjy CreditAttribution: benjy commentedThis looks good to me. +1 for RTBC
Comment #7
alexpottCommitted ac7e61e and pushed to 8.x. Thanks!
Interdiff between #0 and #5