Comments

lee20’s picture

Status: Active » Needs review
StatusFileSize
new693 bytes
aleksijohansson’s picture

Status: Needs review » Reviewed & tested by the community

Patch seems to be working fine!

dmsmidt’s picture

+1 for getting this in, works like a charm.

br0ken’s picture

Status: Reviewed & tested by the community » Needs work

Integration does not work now! When I'm creating a feature, then I have features[commerce_customer_type][] = prescriber in info file, but in code we can see empty function that export nothing: commerce_customer_features_export_render().

mglaman’s picture

Component: Code » Customer Profiles
jorgegc’s picture

Hi @BR0kEN, what integration are you talking about? As far as I am concerned all this module does at the moment is add an entry to your module's .info file like this "features[commerce_customer][] = billing" and tell Features what fields to add as a dependency.

The patch in #1 actually works. I just don't understand why somebody would want to have features export nothing. What am I missing here?

damienmckenna’s picture

Title: Commerce customer profile type export broken » Commerce customer profile types not exporting
Status: Needs work » Needs review
StatusFileSize
new1.53 KB

The patch doesn't resolve the problem for me - I add customer types to the export but they aren't added to the features.inc file. This patch updates commerce_customer_features_export_render() to add the export type.

damienmckenna’s picture

StatusFileSize
new1.53 KB

This corrects some mistaken "coupon" strings with "customer".

damienmckenna’s picture

StatusFileSize
new1.53 KB

Sorry, coding while tired.

jorgegc’s picture

Hi @DamienMcKenna, although your patch fixes the export part, the hook_commerce_customer_default_types doesn't actually work. I have tried changing the details in the hook but features doesn't pick them up.

I am uploading a new patch that changes the default hook.

sumthief’s picture

Hi! Patch from #10 works for me (now I can to export customer profile types between different instances via features).

I think if there someone else will confirm that this patch works, we can set RTBC for this issue.

br0ken’s picture

Status: Needs review » Reviewed & tested by the community
mglaman’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/commerce_features.module
@@ -37,7 +37,7 @@ function commerce_features_features_api() {
     $features['commerce_order_type'] = array(
       'name' => t('Commerce order types'),
       'features_source' => TRUE,
-      'default_hook' => 'commerce_order_default_types',
+      'default_hook' => 'commerce_customer_profile_type_info',
       'file' => drupal_get_path('module', 'commerce_features') . '/commerce_order_type.features.inc',

No. We should not have order types loaded from the customer profile type.

ssvargass’s picture

StatusFileSize
new1.49 KB

Hi @jorgegc, Your patch is working for me, but is not necessary modify the .module file as @mglaman indicated.

This is the new patch and it's working for me.

mglaman’s picture

Status: Needs work » Needs review
jorgegc’s picture

Hi @ssvargass, thanks for making the changes that @mglaman suggested. I have reviewed the patch in #14 and can confirm that it works as expected. Shall we RTBC?

Cheers!

br0ken’s picture

Status: Needs review » Reviewed & tested by the community

  • mglaman committed 7e86f94 on 7.x-1.x authored by ssvargass
    Issue #2292895 by DamienMcKenna, jorgegc, lee20, ssvargass, BR0kEN,...
mglaman’s picture

Status: Reviewed & tested by the community » Fixed

Committed, thanks everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.