comment_entity_load() adds comment statistics information to entity object on a per-field basis. It gets it's data from read() on comment.statistics. Problem is that read() keyes return array with entity_id, which results in values being overriden if there are more than one comment field on an entity.
Do not key return array by entity_id to actually pass over stats for all fields.
- write fix
- write test coverage
N/A
- array that is returned form CommentStatisticsInterface::read() is slightly changed
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 2292115_7.patch | 3.45 KB | slashrsm |
| #3 | interdiff.txt | 1.82 KB | slashrsm |
| #3 | 2292115_3.patch | 3.45 KB | slashrsm |
| #1 | 2292115_1.patch | 3.45 KB | slashrsm |
Comments
Comment #1
slashrsm commentedComment #3
slashrsm commentedComment #4
larowlanThanks, good find.
Comment #7
slashrsm commentedRe-roll.
Comment #8
slashrsm commentedSimple re-roll.
Comment #9
catchSo fixing this is good, but I think we should also look at whether we actually need this to be loaded into the entity object at all. For listings there is hook_entity_prepare_view() which might well be enough.
Comment #10
alexpottCommitted 8b72eb1 and pushed to 8.x. Thanks!
Comment #11
alexpottWe can explore #9 in another issue.
Comment #13
andypost@catch
Yes we need them, at least for #1920044: Move comment field settings that relate to rendering to formatter options
This is only place where we can load comment field related data
Comment #15
roderikI didn't see this issue until I spotted the commit in the D8 commit log last month...
...this was my fault since I pushed #2259209: Fix CommentStatistics::read() in, which should apparently have been named "break CommentStatistics::read()" instead...
...but since I know I'm the only one using the change in #2259209, and it's not necessary anymore: I'd really like to revert the behavior to before #2259209. See #2318875: Redo CommentStatisticsInterface for details. Sorry, and thanks for the tests.