Coding standards: fix whitespace [#2291885]

Some files have trailing whitespace or extra or missing newlines at the end of the file. Editors that automatically fix this leads to a hassle when making patches.

Comment	File	Size	Author
#5	webform-whitespace-2291885-4.patch	4 KB	DanChadwick
#5
#3	webform_2291885_whitespace.patch	3.27 KB	Liam Morland
#3
#1	webform_2291885_whitespace.patch	3.27 KB	Liam Morland
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #2

DanChadwick CreditAttribution: DanChadwick commented 24 June 2014 at 16:40

Status:

Needs review

» Reviewed & tested by the community

Looks fine to me, but ...

webform.module, line 2879, ..._postvalidate():

I don't see the difference. Maybe tabs vs spaces?

Also in that line, please correct my typo (extra m, missing period):
submmission (e.g
->
submission (e.g.

And commit at your convenience.

BTW, what editors fix file-end white space? Seems heavy-handed.

Comment #3

Liam Morland

English

Ontario, CA 🇨🇦

CreditAttribution: Liam Morland commented 24 June 2014 at 17:58

File	Size
webform_2291885_whitespace.patch	3.27 KB

I don't have commit access. I appear in the list of committers because I was given attribution for patches I wrote. Example of this:

http://cgit.drupalcode.org/webform/commit/?id=9c071d1

Instructions for how to do this are on each person's profile page.

I don't see the difference. Maybe tabs vs spaces?

On line "Validation errors are present" there is a trailing space. I use Textwrangler. It can be turned off, but I usually like it on because it ensures I follow Drupal coding standards without me having to bother checking.

Updated version with typo corrected attached.

Comment #4

24 June 2014 at 19:06

Commit 0118bc3 on 7.x-4.x authored by Liam Morland, committed by DanChadwick:
```
Issue #2291885 by Liam Morland: Fixed hitespace consistency.
```
Commit f016b9b on 8.x-4.x authored by Liam Morland, committed by DanChadwick:
```
Issue #2291885 by Liam Morland: Fixed hitespace consistency.
```

Comment #5

DanChadwick CreditAttribution: DanChadwick commented 24 June 2014 at 19:10

Status:

Reviewed & tested by the community

» Fixed

File	Size
webform-whitespace-2291885-4.patch	4 KB

My mistake. I thought I saw you in the maintainers, but you're right. It was the list of commits.

Re-rolled with e.g. <- period in comment. Note Drupal standard patch naming convention that I used. :)

Thanks for pointing out the attribution. I thought that there was magic sauce in d.o that took user names from commit messages and adjusted the author, but apparently not. I will try to give proper attribution in the future, now that I'm aware of the process. It is rather a pain, what with applying the patch to two branches, copying the commit message, and now looking up the author.

Thanks for your work on this.