Some files have trailing whitespace or extra or missing newlines at the end of the file. Editors that automatically fix this leads to a hassle when making patches.

CommentFileSizeAuthor
#5 webform-whitespace-2291885-4.patch4 KBdanchadwick
#3 webform_2291885_whitespace.patch3.27 KBliam morland
#1 webform_2291885_whitespace.patch3.27 KBliam morland

Comments

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Assigned: liam morland » Unassigned
Status: Active » Needs review
StatusFileSize
new webform_2291885_whitespace.patch3.27 KB

Fix.

danchadwick’s picture

danchadwick commented
Status: Needs review » Reviewed & tested by the community

Looks fine to me, but ...

webform.module, line 2879, ..._postvalidate():

I don't see the difference. Maybe tabs vs spaces?

Also in that line, please correct my typo (extra m, missing period):
submmission (e.g
->
submission (e.g.

And commit at your convenience.

BTW, what editors fix file-end white space? Seems heavy-handed.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
StatusFileSize
new webform_2291885_whitespace.patch3.27 KB

I don't have commit access. I appear in the list of committers because I was given attribution for patches I wrote. Example of this:

http://cgit.drupalcode.org/webform/commit/?id=9c071d1

Instructions for how to do this are on each person's profile page.

I don't see the difference. Maybe tabs vs spaces?

On line "Validation errors are present" there is a trailing space. I use Textwrangler. It can be turned off, but I usually like it on because it ensures I follow Drupal coding standards without me having to bother checking.

Updated version with typo corrected attached.

danchadwick’s picture

danchadwick commented
Status: Reviewed & tested by the community » Fixed
StatusFileSize
new webform-whitespace-2291885-4.patch4 KB

My mistake. I thought I saw you in the maintainers, but you're right. It was the list of commits.

Re-rolled with e.g. <- period in comment. Note Drupal standard patch naming convention that I used. :)

Thanks for pointing out the attribution. I thought that there was magic sauce in d.o that took user names from commit messages and adjusted the author, but apparently not. I will try to give proper attribution in the future, now that I'm aware of the process. It is rather a pain, what with applying the patch to two branches, copying the commit message, and now looking up the author.

Thanks for your work on this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.