next_serial needs to have a default value set in webform_node_defaults() to prevent undefined index errors.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | webform_2291843_next_serial_default.patch | 375 bytes | liam morland |
next_serial needs to have a default value set in webform_node_defaults() to prevent undefined index errors.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | webform_2291843_next_serial_default.patch | 375 bytes | liam morland |
Comments
Comment #1
liam morlandFix.
Comment #2
danchadwick commentedI could not reproduce the error. I know you developed this. Does your next_serial column in your database have a default of 1?
But in any case, I agree that the patch is proper. Clearly there shouldn't be a missing next_serial in the node when it is created. Please commit to d7 and d8 at your convenience.
Comment #3
liam morlandThe database has the default, but I get the error when I load the form settings page. That could be caused by a particularity in our setup, which adds customizations to Webfrom. In any case, I thought that it was proper to have the default provided.
Comment #4
liam morlandIt seems that on a Webform-enabled content type, before any Webform data is saved, there is no row in the webform table, and, therefore, no default value. Save the Form settings page or create a component and the row in webform table is created.
Comment #6
danchadwick commentedCommitted to:
7.x-4.x commit 9f9e787
8.x commit b6e6275 (which has the wrong commit message again, darn it.)
Comment #8
danchadwick commented