When enabled, at each node view the forum module will attempt a vocabulary_load() even when not necessary.

This can be avoided by moving 2 lines of code inside a if. Easy win. If we don't, we'll have the taxonomy term load operation attempted on every page that renders at least one node, even when no forum nodes at all are being manipulated.

CommentFileSizeAuthor
#1 2291081-1-forum_node_view_useless_taxonomy_load.patch756 bytespounard

Comments

pounard’s picture

pounard
Primary language French
commented
Status: Active » Needs review
StatusFileSize
new 2291081-1-forum_node_view_useless_taxonomy_load.patch756 bytes

Here is the patch.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch, failed testing.

Status: Needs work » Needs review

pounard queued 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch for re-testing.

pounard’s picture

pounard
Primary language French
commented
Status: Needs review » Reviewed & tested by the community

Good to go !

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch, failed testing.

pounard’s picture

pounard
Primary language French
commented

I don't even understand why this patch fails one time out of two...

Status: Needs work » Needs review

dcam queued 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Huh... good catch. RTBC +1 from me.

Don't worry about the test failure. It's a fatal error in an unrelated system, indicating the testing client just crashed or something. 7.x patches that are RTBC are constantly having these issues. I have about 24 others in my queue and I have to do upkeep on some of them every day to put them back at RTBC. If it happens again just retest the patch so it will be green and set it back to RTBC.

pounard’s picture

pounard
Primary language French
commented

Thanks, still good to go then.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch, failed testing.

Status: Needs work » Needs review

dcam queued 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch, failed testing.

Status: Needs work » Needs review

pounard queued 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch, failed testing.

Status: Needs work » Needs review

pounard queued 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch, failed testing.

Status: Needs work » Needs review

dcam queued 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch, failed testing.

Status: Needs work » Needs review

dcam queued 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch, failed testing.

Status: Needs work » Needs review

pounard queued 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch, failed testing.

Status: Needs work » Needs review

dcam queued 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch, failed testing.

Status: Needs work » Needs review

dcam queued 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch for re-testing.

dcam’s picture

dcam commented
Title: forum_node_view attempt an unnecessary vocabulary_load() under certain circonstances » forum_node_view attempt an unnecessary vocabulary_load() under certain circumstances
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch, failed testing.

Status: Needs work » Needs review

dcam queued 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch, failed testing.

Status: Needs work » Needs review

dcam queued 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch, failed testing.

Status: Needs work » Needs review

pounard queued 1: 2291081-1-forum_node_view_useless_taxonomy_load.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community
David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

  • David_Rothstein committed ac66040 on 7.x 
    Issue #2291081 by pounard: forum_node_view attempt an unnecessary...
pounard’s picture

pounard
Primary language French
commented

Thanks !

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.