Just upgraded my server to php 5.4 and am getting this on pages:

Strict warning: Declaration of FeedsCommentProcessor::expire() should be compatible with FeedsProcessor::expire(FeedsSource $source, $time = NULL) in _registry_check_code() (line 3174 of drupal7/includes/bootstrap.inc).

CommentFileSizeAuthor
#3 2288317-3.patch447 bytesdonSchoe

Comments

socialnicheguru’s picture

socialnicheguru commented

the line in feeds_comment_processor/FeedsCommentProcessor.inc is public function expire($time = NULL) { which is part of the public expire function

should it be:

  public function expire(FeedsSource $source, $time = NULL) {
donSchoe’s picture

donSchoe commented

+1 also running into this issue.

donSchoe’s picture

donSchoe commented
Assigned: Unassigned » donSchoe
Status: Active » Needs review
StatusFileSize
new 2288317-3.patch447 bytes

#1 does the trick for me. Will attach a patch.

Pass the following option to git commit to attribute authorship to the author:
--author="SocialNicheGuru <git@111846.no-reply.drupal.org>"

socialnicheguru’s picture

socialnicheguru commented

Don't forget about the person who came up with the fix.

donSchoe’s picture

donSchoe commented
Title: PHP 5.4+: Strict warning: Declaration of FeedsCommentProcessor::expire() should be compatible with FeedsProcessor::expire(FeedsSource » [PATCH] PHP 5.4+: Strict warning: Declaration of FeedsCommentProcessor::expire() should be compatible with FeedsProcessor::expire(FeedsSource
Status: Needs review » Reviewed & tested by the community

Oops, sorry. (*ninja-claim* ... :-)
Anyways: RTBC.

leavai’s picture

leavai commented

Hi! I'm new in this... how can I apply this patch?

Thanks!

gabeos’s picture

gabeos commented

You can apply the patch with git, the linux command line tool `patch`,

Instructions (and warnings) here: https://www.drupal.org/patch/apply

  • twistor committed 4ef18ed on 7.x-1.x authored by donSchoe 
    Issue #2288317 by donSchoe, SocialNicheGuru: Strict warning: Declaration...
twistor’s picture

twistor commented
twistor’s picture

twistor commented
Assigned: donSchoe » Unassigned
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

katrien_w’s picture

katrien_w commented

I'm still getting this error on every database update, after applying the patch (and clearing caches).
Using version 7.x-1.0 as part of open atrium distribution 2.50. What else could be wrong?