Configure page title per display

+++ b/src/Plugin/PageVariantBase.php
@@ -324,4 +341,26 @@ abstract class PageVariantBase extends PluginBase implements PageVariantInterfac
+        if ($token_type == 'taxonomy_term') {
+          $token_type = 'term';
+        }

Ugghhhhhhhhh

Otherwise, looks cool.

1. +++ b/src/Plugin/DisplayVariant/BlockDisplayVariant.php
   @@ -306,6 +333,10 @@ class BlockDisplayVariant extends VariantBase implements ContainerFactoryPluginI
   +    if (!empty($form_state['values']['page_title'])) {
   

   Wouldn't this prevent an existing title from being replaced by an empty string?

2. +++ b/src/Plugin/VariantBase.php
   @@ -326,6 +326,40 @@ abstract class VariantBase extends PluginBase implements VariantInterface {
   +        if ($token_type == 'taxonomy_term') {
   +          $token_type = 'term';
   +        }
   

   Let's put an explicit @todo here

3. +++ b/src/Tests/PageNodeSelectionTest.php
   @@ -96,7 +99,14 @@ class PageNodeSelectionTest extends WebTestBase {
        $this->assertNoText('Node View');
   

   This shouldn't care about 'Node View' now

The deriver issue went in.

18: pm-2287733-18.patch queued for re-testing.

Thanks @Berdir!

Ughhh committed from the wrong tab.

Rerolled. Sorry for the confusion.

1. +++ b/src/Plugin/DisplayVariant/BlockDisplayVariant.php
   @@ -70,6 +71,12 @@ class BlockDisplayVariant extends VariantBase implements ContextAwareVariantInte
    
      /**
   +   * The token service.
   +   *
   +   * @var \Drupal\Core\Utility\Token
   +   */
   +
   

   /**
    * The nothing.
    * 
    * @var mixed
    */
   

   Maybe adding a protected $token; would help ;)

2. +++ b/src/Plugin/DisplayVariant/BlockDisplayVariant.php
   @@ -154,6 +166,15 @@ class BlockDisplayVariant extends VariantBase implements ContextAwareVariantInte
   +      '#default_value' => !$this->id() ? $this->executable->getPage()->label() : $this->configuration['page_title'],
   

   I wonder whether it would be possible to use the default_options for that?

3. +++ b/src/Routing/PageManagerRoutes.php
   @@ -86,7 +86,6 @@ class PageManagerRoutes extends RouteSubscriberBase {
              '_page' => $entity_id,
   -          '_title' => $entity->label(),
            ),
   
   +++ b/tests/src/Unit/BlockDisplayVariantTest.php
   diff --git a/tests/src/Unit/PageManagerRoutesTest.php b/tests/src/Unit/PageManagerRoutesTest.php
   index b0a2c78..e1d0ed3 100644
   
   index b0a2c78..e1d0ed3 100644
   --- a/tests/src/Unit/PageManagerRoutesTest.php
   
   --- a/tests/src/Unit/PageManagerRoutesTest.php
   +++ b/tests/src/Unit/PageManagerRoutesTest.php
   
   +++ b/tests/src/Unit/PageManagerRoutesTest.php
   +++ b/tests/src/Unit/PageManagerRoutesTest.php
   @@ -115,9 +115,6 @@ class PageManagerRoutesTest extends UnitTestCase {
   
   @@ -115,9 +115,6 @@ class PageManagerRoutesTest extends UnitTestCase {
          ->method('getPath')
          ->will($this->returnValue('/page1'));
        $page1->expects($this->once())
   -      ->method('label')
   -      ->will($this->returnValue('Page label'));
   -    $page1->expects($this->once())
          ->method('usesAdminTheme')
          ->will($this->returnValue(TRUE));
        $pages['page1'] = $page1;
   @@ -143,7 +140,6 @@ class PageManagerRoutesTest extends UnitTestCase {
   
   @@ -143,7 +140,6 @@ class PageManagerRoutesTest extends UnitTestCase {
        $expected_defaults = array(
          '_entity_view' => '_page',
          '_page' => 'page1',
   -      '_title' => 'Page label',
        );
        $expected_requirements = array(
          '_entity_access' => '_page.view',
   @@ -192,7 +188,6 @@ class PageManagerRoutesTest extends UnitTestCase {
   
   @@ -192,7 +188,6 @@ class PageManagerRoutesTest extends UnitTestCase {
        $expected_defaults = array(
          '_entity_view' => '_page',
          '_page' => 'page1',
   -      '_title' => NULL,
        );
        $expected_requirements = array(
   

   Not really sure about this change. This kind of makes it impossible to render a page as part of a breadcrumb given that _title and _title_callback is used in order to generate those. If you specify #title, it will always win anyway. I wonder whether you could either use the $entity->label() or even the page title in case there is no token in there?

I agree with #33.3, not sure what #33.2 means.

Rerolled

1. +++ b/src/Plugin/DisplayVariant/BlockDisplayVariant.php
   @@ -145,6 +157,7 @@ public function build() {
   +    $build['#title'] = $this->renderPageTitle($this->configuration['page_title']);
   

   Why not wrap this in a conditional?

2. +++ b/src/Routing/PageManagerRoutes.php
   @@ -86,7 +86,6 @@ protected function alterRoutes(RouteCollection $collection) {
   -          '_title' => $entity->label(),
   

   I think this could be kept, and just let the #title override it.

Sorry for holding this up so long. Thanks @Berdir.