Hi,

When using flag on php 5.3.6 I get the following error:

Strict warning: Only variables should be passed by reference in flag_views_flag_default() (line 267 of ../flag/includes/views/flag.views.inc)

This is because php 5.3.6 does'nt allow an array shift directly on the function flag_get_flags($entity_type).

Herefore I have created a patch to return the value to a variable first.

CommentFileSizeAuthor
#1 flag-warning-flag_get_flags-2286959-1.patch567 bytesericclaeren

Comments

ericclaeren’s picture

ericclaeren commented
StatusFileSize
new flag-warning-flag_get_flags-2286959-1.patch567 bytes
joachim’s picture

joachim commented
Status: Needs review » Fixed

Gah stupid PHP!!!

Thanks for the patch! Committed.

  • Commit 5498328 on 7.x-3.x authored by dreamlabs, committed by joachim: 
    Issue #2286959 by dreamlabs: Fixed warning in flag_views_flag_default.
ericclaeren’s picture

ericclaeren commented

Thanks for comitting joachim.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.