When using Views UI in an RTL language, The dropbuttons appear right-aligned, covering the section title of the Views UI interface.
When Switching interface direction, Dropbuttons should appear on the left side, not on the right side.

CommentFileSizeAuthor
#8 interdiff-1-7.txt591 bytescs_shadow
#8 views_ui-2286923-8.patch642 bytescs_shadow
#2 Frontpage_view_d8_dropbutton_position_patched.png84.27 KBalayham
#1 views_ui_dripbuttons_rtl_align-2286923-1.patch539 bytesalayham
Drupal-rtl-views_ui-dripbutton.png92.64 KBalayham

Comments

alayham’s picture

alayham commented
Status: Active » Needs review
StatusFileSize
new views_ui_dripbuttons_rtl_align-2286923-1.patch539 bytes

Patch to fix dropbutton alignment in RTL languages.

alayham’s picture

alayham commented
StatusFileSize
new Frontpage_view_d8_dropbutton_position_patched.png84.27 KB

The home page view after this patch is applied.
the frontpage view after the patch

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

much better!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: views_ui_dripbuttons_rtl_align-2286923-1.patch, failed testing.

alayham’s picture

alayham commented

1: views_ui_dripbuttons_rtl_align-2286923-1.patch queued for re-testing.

alayham’s picture

alayham commented
Status: Needs work » Reviewed & tested by the community

Back to "reviews and tested by the community.

The test failure was not related to this patch. Now it passes.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/views_ui/css/views_ui.admin.theme.css
@@ -1151,6 +1151,11 @@ div.messages {
+  right:auto;

this should have a space.. right: auto

Also the corresponding ltr rules should have /* LTR */

cs_shadow’s picture

cs_shadow commented
Status: Needs work » Needs review
StatusFileSize
new views_ui-2286923-8.patch642 bytes
new interdiff-1-7.txt591 bytes

Updated patch in #1 as per suggestions in #7.

alayham’s picture

alayham commented
Status: Needs review » Reviewed & tested by the community

This is related to #2287381: views_ui dropbuttons display is not RTL friendly and should be committed as well to fix the issue.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Looks like Alex's feedback was addressed.

Committed and pushed to 8.x. Thanks!

  • webchick committed 883577b on 8.x 
    Issue #2286923 by cs_shadow, alayham: Fixed views_ui dropbuttons are not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.