Port to Drupal 8

Sure. Branched & pushed. Go nuts! :)

That sounds like an excellent start. Nice work!

I don't want to get involved in the D8 side yet, but if someone would like to confirm that this is a good basis for continuing efforts, then I'll be happy to commit this to the 8.x branch, so that the subsequent patches can be smaller.

anavarre: perhaps you are in a position to provide confirmation?

n.b. I'm setting this to "Needs Review" for the above reason, but with the expectation that we'll bump it back to "Active" after the initial commit.

Additional things I noticed with the patch initially...

• drupal8-version.patch:45: new blank line at EOF.
• seckit.info still exists
• seckit.test still exists
• anavarre's changes to t() above

Fix patch #9, add compatibility with Drupal 8 alpha14 and other fixies.

Cross-referencing with #2606748: [seckit] Security Kit in the Drupal 8 Contrib Porting Tracker issue queue.

Updated the patch to get it working again with rc2:

• Added JS library for settings form
• Converted $form_state to use classed object
• Added URL class to fix URL issues in settings form
• Removed redundant seckit.settings.yml~ backup file

There is still plenty of work to do on this module including:

• Figuring out what functionality, if any, has moved into core
• Re-implement drupal_add_http_header() usage as it has been deprecated

Thanks badjava.

This seems like a good time to reiterate my earlier comment:

if someone would like to confirm that this is a good basis for continuing efforts, then I'll be happy to commit this to the 8.x branch, so that the subsequent patches can be smaller.

@jweowu Yes, I think this is a good starting point to build on.

I just discovered that this patch will need to be committed in order to use this module on sites that use Composer. Can we get this committed soon?

Committed.

luizsgpetri, I don't know why, but your posts in this issue are now listed as Anonymous? I could see that you're still active here, with commits in other Drupal projects, so I lifted the attribution details from one of those. I hope that's ok.

I'm pretty sure "Needs work" is still correct here.

It feels sensible to keep development in this issue until we're at a reasonably stable point? We can just hide the redundant files as things get committed along the way.

So now there's a 8.x-1.x can someone make a release so we can create issues against it.

I just got the following issue when running all tests against my install.

php ./core/scripts/run-tests.sh --verbose --keep-results --color --concurrency 30 --php `which php` --sqlite /tmp/test.sqlite --url http://localhost:8080 --all
exception 'Drupal\simpletest\Exception\MissingGroupException' with message 'Missing @group annotation in Drupal\seckit\Tests\SecKitCSPCaseTest' in /home/travis/build/timmillwood/d8/docroot/core/modules/simpletest/src/TestDiscovery.php:329
Stack trace:
#0 /home/travis/build/timmillwood/d8/docroot/core/modules/simpletest/src/TestDiscovery.php(162): Drupal\simpletest\TestDiscovery::getTestInfo('Drupal\\seckit\\T...', '/**\n * Function...')
#1 /home/travis/build/timmillwood/d8/docroot/core/modules/simpletest/simpletest.module(510): Drupal\simpletest\TestDiscovery->getTestClasses(NULL)
#2 /home/travis/build/timmillwood/d8/docroot/core/scripts/run-tests.sh(880): simpletest_test_get_all(NULL)
#3 /home/travis/build/timmillwood/d8/docroot/core/scripts/run-tests.sh(99): simpletest_script_get_test_list()

I wasn't expecting to do that yet, but I'll defer to the people working on the code. If they'd prefer separate issues at this stage, we can do that; otherwise we'll continue to isolate the 8.x development in here.

As D8 has deprecated drupal_add_http_header() function. I've created a patch for 8.x-1.x branch that utilizes Response object.

Patch applies cleanly for me and fixes the drupal_add_http_header() function deprecation issue.

With this patch we should have a functional D8 port. We need to get this patch committed and then a release cut so we can start filing individual issues against 8.x.

I am willing to help with ongoing support of this module so if someone wants to add me as a maintainer, I would be willing to take a more active role particularly with the D8 version.

I'd second @badjava to be co-maintainer.

I second the move for a 8.x release so we can get this port going!

FYI I'm on holiday for another week and a bit, and have extremely limited access to anything in the meantime. Please continue to create patches if you have improvements, and I will follow up with commits and a release once I'm back. Thanks!

I've created a 8.x-1.x-dev release after that last commit. It should be visible shortly. Marking this issue as Fixed.