I've been seeing this show up in the logs after a cache clear:
Undefined index: TABLE_NAME in remote_entity_get_query_table_info() (line 190 of remote_entity.module).

I'll have a patch for this in a minute.

CommentFileSizeAuthor
#1 check_for_table_connection_info-2284683-1.patch807 bytescolan

Comments

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Status: Active » Needs review
StatusFileSize
new check_for_table_connection_info-2284683-1.patch807 bytes

See attached.

joachim’s picture

joachim commented
Status: Needs review » Fixed

I think with my usage of the module, I always need to define table info, but by the sounds of it you don't. So makes sense. Committed, thanks!

BTW, I'm curious about what type of remote data you're using this with!

  • Commit 3f90046 on 7.x-1.x authored by colan, committed by joachim: 
    Issue #2284683 by colan: Fixed undefined index error in...
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

BTW, I'm curious about what type of remote data you're using this with!

I'm using a REST API as the back-end data store so there are actually no remote tables that I need to worry about. I didn't really understand what the point of defining a remote table if the source is over Web services. Maybe that's the problem. Should I not be defining a "remote base table" in hook_entity_info()?

joachim’s picture

joachim commented

> Should I not be defining a "remote base table" in hook_entity_info()?

Yes, you should.

The extra table info in hook_remote_entity_query_table_info() came about because it turned out that with MS Dynamics I needed tons of extra data about field types and relationships and so on to make properly-formed queries and remote saves. It felt like too much to dump all that into hook_entity_info(), as that's loaded just about every page load.

I think Remote Entity is going to need a bit of a rethink for a 2.0 version because there are quite a few decisions that I made when backed into a corner and things that got tacked on not very elegantly, but that's not going to be until the end of the current phase of the project I use it on -- probably in the late autumn.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

Good to know. I just made it the same as the "base table" as in the Programming Drupal 7 Entities example, but I don't think it's being used anywhere in my case.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.