Currently the Submit button has the custom name defined in the webform (or Submit if none). When editing an already-submitted webform, this leads to confusion.

Proposed change. Always call the submit button for an existing, complete (non-draft) webform "Save", making this consistent with editing content and other data.

Comments welcome, particularly from quicksketch.

CommentFileSizeAuthor
#2 webform-submit_button_name-2284599-1.patch3.1 KBdanchadwick

Comments

  • Commit 6d1ad32 on 7.x-4.x by DanChadwick: 
    Issue #2284599: Changed Submit button to Save for finished submission...
  • Commit 963dca7 on 8.x-4.x by DanChadwick:
    Issue #2284599: Changed Submit button to Save for finished submission...
danchadwick’s picture

danchadwick commented
Version: 7.x-4.x-dev » 8.x-4.x-dev
Status: Active » Fixed
StatusFileSize
new webform-submit_button_name-2284599-1.patch3.1 KB

I've implemented this change. In the case where an already-completed webform is being edited, the 'submit' button is called 'Save' rather than the standard 'Submit' or whatever the user customized it to in the webform options. While one might add yet-another customized button label, I felt that the circumstance is sufficiently rare, and often encountered by an administrator rather than the form-filler-outer, that this was unneeded. If others disagree, I will add an option.

At the same time, I noticed a code redundancy in creating the submit button which could easily be eliminated by observing that for a 1 page form, the current page == the number of pages. The patch seems big, but really is mostly code indentation change due to the eliminate of a big if clause.

I tested this with single and multi-page forms, with and without preview, with and without save-as-draft, with and without already being submitted.

Committed to 7.x-4.x and 8.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.