Comments

geberele’s picture

geberele’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: features-drush_features_components_d6-2283617-0.patch, failed testing.

geberele’s picture

Status: Needs work » Needs review
geberele’s picture

Not sure why the test is failing, the patch works fine on branch 6.x-1.x

$ git apply -v features-drush_features_components_d6-2283617-0.patch

Checking patch features.drush.inc...
Checking patch features.module...
Applied patch features.drush.inc cleanly.
Applied patch features.module cleanly.

Status: Needs review » Needs work

The last submitted patch, 1: features-drush_features_components_d6-2283617-0.patch, failed testing.

geberele’s picture

geberele’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: features-drush_features_components_d6-2283617-1.patch, failed testing.

geberele’s picture

geberele’s picture

Status: Needs work » Needs review
geberele’s picture

Status: Needs review » Needs work

The last submitted patch, 10: features-drush_features_components_d6-2283617-2.patch, failed testing.

geberele’s picture

StatusFileSize
new8.91 KB
geberele’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 14: features-drush_features_components_d6-2283617-3.patch, failed testing.

geberele’s picture

StatusFileSize
new140.75 KB

The patch drush_features_components_d6-2283617-3.patch is fine, it fails because there are exceptions not related to this patch.

[08:52:02] Log initialized (/var/lib/drupaltestbot/sites/default/files/review.test_808448.pifr_simpletest.features-drush_features_components_d6-2283617-3.patch.1402674722.log)
[08:52:02] Review timestamp: (Fri, 06/13/2014 - 08:52)
[08:52:02] Review host: (ec2-54-196-147-131)
[08:52:02] Operations:Array
(
[0] => setup
[1] => fetch
[2] => checkout
[3] => check
[4] => apply
[5] => syntax
[6] => install
[7] => review
)

[08:52:02] Result Codes: Array
(
[fail] => 9
[pass] => 10
)

[08:52:02] Environment variables and review information initialized.
[08:52:02] core_url = [git://git.drupal.org/project/drupal.git]; Test repository = [git://git.drupal.org/project/features.git]
[08:52:02] Project directory is [features]
[08:52:02] Review started.
[08:52:02] Test: Array
(
[test_id] => 808448
[review] => Array
(
[plugin] => pifr_simpletest
[argument] => Array
(
[test.title] =>
[test.directory.review] => Array
(
[0] => sites/default/modules/features
)

[test.directory.apply] =>
[test.directory.dependency] =>
[test.files] => Array
(
)

[test.extensions] => Array
(
[0] => php
[1] => inc
[2] => install
[3] => module
[4] => test
)

[drupal.core.version] => 6
[drupal.core.url] => git://git.drupal.org/project/drupal.git
[drupal.modules] => Array
(
)

[drupal.user] => admin
[drupal.pass] =>
[drupal.variables] => Array
(
)

[simpletest.tests] => Array
(
)

[simpletest.db] =>
[test.php.version] => 5.3
)

)

[vcs] => Array
(
[main] => Array
(
[repository] => Array
(
[type] => git
[url] => git://git.drupal.org/project/drupal.git
)

[vcs_identifier] => 6.x
)

[dependencies] => Array
(
[1] => Array
(
[repository] => Array
(
[type] => git
[url] => git://git.drupal.org/project/cck.git
)

[vcs_identifier] => 6.x-2.9
)

[2] => Array
(
[repository] => Array
(
[type] => git
[url] => git://git.drupal.org/project/views.git
)

[vcs_identifier] => 6.x-2.16
)

[3] => Array
(
[repository] => Array
(
[type] => git
[url] => git://git.drupal.org/project/features.git
)

[vcs_identifier] => 6.x-1.2
)

[4] => Array
(
[repository] => Array
(
[type] => git
[url] => git://git.drupal.org/project/simpletest.git
)

[vcs_identifier] => 6.x-2.x
)

)

)

[files] => Array
(
[0] => https://drupal.org/files/issues/features-drush_features_components_d6-22...
)

)

[08:52:02] Operations: Array
(
[0] => setup
[1] => fetch
[2] => checkout
[3] => check
[4] => apply
[5] => syntax
[6] => install
[7] => review
)

[08:52:02] Invoking operation [setup]...
[08:52:02] Command [chmod -R u+rw sites/default/files/checkout 2>&1] succeeded.
[08:52:02] Command [rm -rf sites/default/files/checkout 2>&1] succeeded.
[08:52:02] Command [rm -rf sites/default/files/review 2>&1] succeeded.
[08:52:02] Database backend [mysql] loaded.
[08:52:02] Invoking operation [fetch]...
[08:52:03] Fetched [features-drush_features_components_d6-2283617-3.patch].
[08:52:03] Invoking operation [checkout]...
[08:52:03] Version control system backend [git] loaded.
[08:52:07] Command [git clone 'git://git.drupal.org/project/drupal.git' 'checkout' --reference /var/cache/git/reference 2>&1] succeeded.
[08:52:08] Command [git --work-tree='checkout' --git-dir='checkout/.git' checkout '6.x' 2>&1] succeeded.
[08:52:08] Command [git --work-tree='checkout' --git-dir='checkout/.git' status 2>&1] succeeded.
[08:52:08] Command [git --work-tree='checkout' --git-dir='checkout/.git' log --oneline -1 2>&1] succeeded
Duration: 0 seconds
Directory: [/var/lib/drupaltestbot/sites/default/files]
Completion status: [0]
Output: [80cf244 Issue #2276469 by decibel.places: Fixed robots.txt syntax checking link broken.].
[08:52:08] Main branch [6.x] checkout [complete].
[08:53:33] Command [git clone 'git://git.drupal.org/project/cck.git' '/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/cck' --reference /var/cache/git/reference 2>&1] succeeded.
[08:53:33] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/cck' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/cck/.git' checkout '6.x-2.9' 2>&1] succeeded.
[08:53:33] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/cck' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/cck/.git' status 2>&1] succeeded.
[08:53:33] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/cck' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/cck/.git' log --oneline -1 2>&1] succeeded
Duration: 0 seconds
Directory: [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules]
Completion status: [0]
Output: [fa41f80 This commit was manufactured as part of Drupal's Great Git Migration to create tag 'DRUPAL-6--2-9'.].
[08:53:33] Dependency branch [6.x-2.9] checkout [complete].
[08:54:01] Command [git clone 'git://git.drupal.org/project/views.git' '/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/views' --reference /var/cache/git/reference 2>&1] succeeded.
[08:54:01] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/views' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/views/.git' checkout '6.x-2.16' 2>&1] succeeded.
[08:54:01] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/views' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/views/.git' status 2>&1] succeeded.
[08:54:01] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/views' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/views/.git' log --oneline -1 2>&1] succeeded
Duration: 0 seconds
Directory: [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules]
Completion status: [0]
Output: [049f173 #1330716 by dereine: Take sure that using a view via views_get_current_view doesn't break the site. If it's empty throw some helpful debugging message].
[08:54:01] Dependency branch [6.x-2.16] checkout [complete].
[08:55:25] Command [git clone 'git://git.drupal.org/project/features.git' '/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/features' --reference /var/cache/git/reference 2>&1] succeeded.
[08:55:25] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/features' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/features/.git' checkout '6.x-1.2' 2>&1] succeeded.
[08:55:25] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/features' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/features/.git' status 2>&1] succeeded.
[08:55:25] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/features' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/features/.git' log --oneline -1 2>&1] succeeded
Duration: 0 seconds
Directory: [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules]
Completion status: [0]
Output: [0b1aae3 Issue #1313744 by TravisCarden: Fixed Sort 'Edit components' SELECT alphabetically.].
[08:55:25] Dependency branch [6.x-1.2] checkout [complete].
[08:56:49] Command [git clone 'git://git.drupal.org/project/simpletest.git' '/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest' --reference /var/cache/git/reference 2>&1] succeeded.
[08:56:49] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest/.git' checkout '6.x-2.x' 2>&1] succeeded.
[08:56:49] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest/.git' status 2>&1] succeeded.
[08:56:49] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest/.git' log --oneline -1 2>&1] succeeded
Duration: 0 seconds
Directory: [/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules]
Completion status: [0]
Output: [c4d3a3e Issue #1177106: Fixed PIFR cannot attempt to install Drupal 8 with email element in installer form (from core patch #1174620).].
[08:56:49] Dependency branch [6.x-2.x] checkout [complete].
[08:56:49] Invoking operation [check]...
[08:56:49] Invoking operation [apply]...
[08:56:49] Command [git apply --check -p1 /var/lib/drupaltestbot/sites/default/files/review/features-drush_features_components_d6-2283617-3.patch 2>&1] succeeded.
[08:56:49] Command [git apply -v -p1 /var/lib/drupaltestbot/sites/default/files/review/features-drush_features_components_d6-2283617-3.patch 2>&1] succeeded.
[08:56:49] Applied [features-drush_features_components_d6-2283617-3.patch] to:
> features.drush.inc
> features.module
[08:56:49] Invoking operation [syntax]...
[08:56:49] Command [php -l -f './sites/default/modules/features/features.drush.inc' 2>&1] succeeded.
[08:56:49] Command [php -l -f './sites/default/modules/features/features.module' 2>&1] succeeded.
[08:56:49] Checked [2 of 2] relevant file(s) for syntax.
[08:56:49] Invoking operation [install]...
[08:56:49] drush si command=cd sites/default/files/checkout && drush si -y --db-url=mysql://drupaltestbot-my:6AT1VPWGvLZx@localhost/drupaltestbotmysql --clean-url=0 --account-name=admin --account-pass=drupal --account-mail=admin@example.com
[08:56:52] Command [cd sites/default/files/checkout && drush si -y --db-url=mysql://drupaltestbot-my:6AT1VPWGvLZx@localhost/drupaltestbotmysql --clean-url=0 --account-name=admin --account-pass=drupal --account-mail=admin@example.com 2>&1] succeeded
Duration: 3 seconds
Directory: [/var/lib/drupaltestbot]
Completion status: [0]
Output: [PHP Warning: Module 'apc' already loaded in Unknown on line 0
PHP Warning: Module 'curl' already loaded in Unknown on line 0
PHP Warning: Module 'gd' already loaded in Unknown on line 0
PHP Warning: Module 'imap' already loaded in Unknown on line 0
PHP Warning: Module 'intl' already loaded in Unknown on line 0
PHP Warning: Module 'mcrypt' already loaded in Unknown on line 0
PHP Warning: Module 'mysql' already loaded in Unknown on line 0
PHP Warning: Module 'mysqli' already loaded in Unknown on line 0
PHP Warning: Module 'PDO' already loaded in Unknown on line 0
PHP Warning: Module 'pdo_mysql' already loaded in Unknown on line 0
PHP Warning: Module 'pdo_sqlite' already loaded in Unknown on line 0
PHP Warning: Module 'sqlite3' already loaded in Unknown on line 0
PHP Warning: Module 'xmlrpc' already loaded in Unknown on line 0
PHP Warning: Module 'xsl' already loaded in Unknown on line 0
You are about to create a /var/lib/drupaltestbot/sites/default/files/checkout/sites/default/settings.php file and DROP all tables in your 'drupaltestbotmysql' database. Do you want to continue? (y/n): y
Starting Drupal installation. This takes a few seconds ... [ok]
Installation complete. User name: admin User password: drupal [ok]].
[08:56:52] Command [cd /var/lib/drupaltestbot 2>&1] succeeded.
[08:56:52] Command [cd sites/default/files/checkout && drush vset simpletest_clear_results '0' 2>&1] succeeded
Duration: 0 seconds
Directory: [/var/lib/drupaltestbot]
Completion status: [0]
Output: [PHP Warning: Module 'apc' already loaded in Unknown on line 0
PHP Warning: Module 'curl' already loaded in Unknown on line 0
PHP Warning: Module 'gd' already loaded in Unknown on line 0
PHP Warning: Module 'imap' already loaded in Unknown on line 0
PHP Warning: Module 'intl' already loaded in Unknown on line 0
PHP Warning: Module 'mcrypt' already loaded in Unknown on line 0
PHP Warning: Module 'mysql' already loaded in Unknown on line 0
PHP Warning: Module 'mysqli' already loaded in Unknown on line 0
PHP Warning: Module 'PDO' already loaded in Unknown on line 0
PHP Warning: Module 'pdo_mysql' already loaded in Unknown on line 0
PHP Warning: Module 'pdo_sqlite' already loaded in Unknown on line 0
PHP Warning: Module 'sqlite3' already loaded in Unknown on line 0
PHP Warning: Module 'xmlrpc' already loaded in Unknown on line 0
PHP Warning: Module 'xsl' already loaded in Unknown on line 0
simpletest_clear_results was set to "0". [success]].
[08:56:52] Command [cd /var/lib/drupaltestbot 2>&1] succeeded.
[08:56:52] Command [cd sites/default/files/checkout && drush vset simpletest_verbose '0' 2>&1] succeeded
Duration: 0 seconds
Directory: [/var/lib/drupaltestbot]
Completion status: [0]
Output: [PHP Warning: Module 'apc' already loaded in Unknown on line 0
PHP Warning: Module 'curl' already loaded in Unknown on line 0
PHP Warning: Module 'gd' already loaded in Unknown on line 0
PHP Warning: Module 'imap' already loaded in Unknown on line 0
PHP Warning: Module 'intl' already loaded in Unknown on line 0
PHP Warning: Module 'mcrypt' already loaded in Unknown on line 0
PHP Warning: Module 'mysql' already loaded in Unknown on line 0
PHP Warning: Module 'mysqli' already loaded in Unknown on line 0
PHP Warning: Module 'PDO' already loaded in Unknown on line 0
PHP Warning: Module 'pdo_mysql' already loaded in Unknown on line 0
PHP Warning: Module 'pdo_sqlite' already loaded in Unknown on line 0
PHP Warning: Module 'sqlite3' already loaded in Unknown on line 0
PHP Warning: Module 'xmlrpc' already loaded in Unknown on line 0
PHP Warning: Module 'xsl' already loaded in Unknown on line 0
simpletest_verbose was set to "0". [success]].
[08:56:52] Command [cd /var/lib/drupaltestbot 2>&1] succeeded.
[08:56:52] Invoking operation [review]...
[08:56:52] Applying in /var/lib/drupaltestbot/sites/default/files/checkout file=/var/lib/drupaltestbot/sites/all/modules/project_issue_file_review/review/simpletest/D6-core-simpletest.patch
[08:56:52] Command [git apply --check -p1 /var/lib/drupaltestbot/sites/all/modules/project_issue_file_review/review/simpletest/D6-core-simpletest.patch 2>&1] succeeded.
[08:56:52] Command [git apply -v -p1 /var/lib/drupaltestbot/sites/all/modules/project_issue_file_review/review/simpletest/D6-core-simpletest.patch 2>&1] succeeded.
[08:56:52] Completed Drupal 6 SimpleTest installation.
[08:56:53] Command [cd sites/default/files/checkout && drush en -y simpletest 2>&1] succeeded
Duration: 1 seconds
Directory: [/var/lib/drupaltestbot]
Completion status: [0]
Output: [PHP Warning: Module 'apc' already loaded in Unknown on line 0
PHP Warning: Module 'curl' already loaded in Unknown on line 0
PHP Warning: Module 'gd' already loaded in Unknown on line 0
PHP Warning: Module 'imap' already loaded in Unknown on line 0
PHP Warning: Module 'intl' already loaded in Unknown on line 0
PHP Warning: Module 'mcrypt' already loaded in Unknown on line 0
PHP Warning: Module 'mysql' already loaded in Unknown on line 0
PHP Warning: Module 'mysqli' already loaded in Unknown on line 0
PHP Warning: Module 'PDO' already loaded in Unknown on line 0
PHP Warning: Module 'pdo_mysql' already loaded in Unknown on line 0
PHP Warning: Module 'pdo_sqlite' already loaded in Unknown on line 0
PHP Warning: Module 'sqlite3' already loaded in Unknown on line 0
PHP Warning: Module 'xmlrpc' already loaded in Unknown on line 0
PHP Warning: Module 'xsl' already loaded in Unknown on line 0
The following extensions will be enabled: simpletest
Do you really want to continue? (y/n): y
simpletest was enabled successfully. [ok]
simpletest defines the following permissions: administer unit tests
The directory sites/default/files/simpletest has been created. [status]].
[08:56:53] Command [cd /var/lib/drupaltestbot 2>&1] succeeded.
[08:56:53] Scanning sites/default/files/checkout/sites/default/modules/features for .test files.
[08:56:53] Scanning sites/default/files/checkout/sites/default/modules/features for /Tests/*.php files.
[08:56:53] Cleaning run-tests.sh environment.
[08:56:53] Command [/usr/bin/php ./scripts/run-tests.sh --concurrency 32 --php /usr/bin/php --url http://ec2-54-196-147-131.compute-1.amazonaws.com/checkout --file sites/default/modules/features/tests/features.test --clean 2>&1] succeeded.
[08:56:53] Initiating run-tests.sh.
[08:56:57] Command [/usr/bin/php ./scripts/run-tests.sh --concurrency 32 --php /usr/bin/php --url http://ec2-54-196-147-131.compute-1.amazonaws.com/checkout --file sites/default/modules/features/tests/features.test 2>&1] succeeded
Duration: 4 seconds
Directory: [/var/lib/drupaltestbot/sites/default/files/checkout]
Completion status: [0]
Output: [PHP Warning: Module 'apc' already loaded in Unknown on line 0
PHP Warning: Module 'curl' already loaded in Unknown on line 0
PHP Warning: Module 'gd' already loaded in Unknown on line 0
PHP Warning: Module 'imap' already loaded in Unknown on line 0
PHP Warning: Module 'intl' already loaded in Unknown on line 0
PHP Warning: Module 'mcrypt' already loaded in Unknown on line 0
PHP Warning: Module 'mysql' already loaded in Unknown on line 0
PHP Warning: Module 'mysqli' already loaded in Unknown on line 0
PHP Warning: Module 'PDO' already loaded in Unknown on line 0
PHP Warning: Module 'pdo_mysql' already loaded in Unknown on line 0
PHP Warning: Module 'pdo_sqlite' already loaded in Unknown on line 0
PHP Warning: Module 'sqlite3' already loaded in Unknown on line 0
PHP Warning: Module 'xmlrpc' already loaded in Unknown on line 0
PHP Warning: Module 'xsl' already loaded in Unknown on line 0

Drupal test run
---------------

Tests to be run:
- Component tests (FeaturesUserTestCase)

Test run started: Fri, 06/13/2014 - 15:56

Test summary:
-------------

PHP Warning: Module 'apc' already loaded in Unknown on line 0
PHP Warning: Module 'curl' already loaded in Unknown on line 0
PHP Warning: Module 'gd' already loaded in Unknown on line 0
PHP Warning: Module 'imap' already loaded in Unknown on line 0
PHP Warning: Module 'intl' already loaded in Unknown on line 0
PHP Warning: Module 'mcrypt' already loaded in Unknown on line 0
PHP Warning: Module 'mysql' already loaded in Unknown on line 0
PHP Warning: Module 'mysqli' already loaded in Unknown on line 0
PHP Warning: Module 'PDO' already loaded in Unknown on line 0
PHP Warning: Module 'pdo_mysql' already loaded in Unknown on line 0
PHP Warning: Module 'pdo_sqlite' already loaded in Unknown on line 0
PHP Warning: Module 'sqlite3' already loaded in Unknown on line 0
PHP Warning: Module 'xmlrpc' already loaded in Unknown on line 0
PHP Warning: Module 'xsl' already loaded in Unknown on line 0
Component tests 33 passes, 0 fails, and 80 exceptions

Test run duration: 3 sec].
[08:56:57] Command [/usr/bin/php ./scripts/run-tests.sh --php /usr/bin/php --url http://ec2-54-196-147-131.compute-1.amazonaws.com/checkout --file sites/default/modules/features/tests/features.test --list 2>&1] succeeded.
[08:56:57] Review complete. test_id=808448 result code=9 details=Array
(
[@pass] => 33
[@fail] => 0
[@exception] => 80
[@debug] => 0
)

[08:56:57] Static variables reset.

geberele’s picture

Status: Needs work » Needs review

joachim’s picture

I've applied the patch and I can confirm it works great! I've sent it for a re-test; if that's green I'll RTBC it.

Very glad to see this, as it's become a part of my workflow on D7 sites and I was missing it when working on old D6 sites!

Thank you geberele for the backport! :)

Status: Needs review » Needs work

The last submitted patch, 14: features-drush_features_components_d6-2283617-3.patch, failed testing.

jwilson3’s picture

Version: 6.x-1.2 » 6.x-1.x-dev
Status: Needs work » Needs review
StatusFileSize
new8.92 KB
new922 bytes

The patch no longer applied against 6.x-1.x-dev (6.x-1.2+19-dev) because the module already contains a function called _drush_features_component_list which is used by the features-add command.

So I've rerolled this and renamed all of the functions to use the plural _drush_features_components_list().