Problem/Motivation

When you collapse fieldgroups in a form that has more than one, they seem to float together.

Here's a screenshot of admin/config/development/performance.

stark fieldgroups

The problem is, Firefox is not supporting Details & Summary elements, so there is no proper default block element style (http://caniuse.com/#feat=details)

Proposed resolution

Remaining tasks

(done) patch
(done) review
(done) issue summary update
(done) add screenshot for after fix to show works
review patch issue several more times
review patch in IE, since IE is also not supporting Details & Summary elements

User interface changes

Here's a screenshot of admin/config/development/performance after applying the patch.

API changes

CommentFileSizeAuthor
#9 stark_fieldgroup_after_patch.jpg176.01 KBkillerpoke
#6 stark_firefox_compatibility-2282133-6.patch392 bytesbasvredeling
stark fieldgroup.png42.33 KBjoachim

Comments

joachim’s picture

joachim commented
Issue summary: View changes
joachim’s picture

joachim commented
Title: fieldgroups are broken in Stark theme » fieldsets are broken in Stark theme
joachim’s picture

joachim commented
Issue summary: View changes
svenryen’s picture

svenryen commented
Issue tags: +Amsterdam2014

I'm looking at this issue and it's due to the default user agent css in Firefox not having display: block; as a default for the tags used.

The issue only appears in Firefox.

basvredeling’s picture

basvredeling
Primary language Dutch
Location Amsterdam
commented

Working on it @DrupalCon A'dam

basvredeling’s picture

basvredeling
Primary language Dutch
Location Amsterdam
commented
Status: Active » Needs review
StatusFileSize
new stark_firefox_compatibility-2282133-6.patch392 bytes

This patch fixes the firefox compatibility for both the details and summary html5 tags.
Perhaps the Stark theme needs a separate compatibility css section or file just to keep the core layout.css to the very basics.

killerpoke’s picture

killerpoke commented

I just tested patch: stark_firefox_compatibility-2282133-6.patch.
I could reproduce the problem with Firefox (32.0.2). After applying the patch, fieldsets are displayed correctly in Firefox.
I also tested this patch for side effects in Chrome 37 and Safari 7.0.6. I couldn't found any side effects.

This patch looks good to me.

killerpoke’s picture

killerpoke commented
Status: Needs review » Reviewed & tested by the community
killerpoke’s picture

killerpoke commented
Issue summary: View changes
StatusFileSize
new stark_fieldgroup_after_patch.jpg176.01 KB
killerpoke’s picture

killerpoke commented
Issue summary: View changes
killerpoke’s picture

killerpoke commented
Issue summary: View changes
BrechtRyckaert’s picture

BrechtRyckaert commented

Windows browsers:
Tested in IE 11.0.9600.17278. No issue here without patching.
Tested in Firefox 32.0.3. No issue without patching.

After patching:
Tested in IE 11.0.9600.17278. No issue here with patching.
Tested in Firefox 32.0.3. No issue with patching.

Operating system was Windows 8.1 Pro, 64 bit version.

svenryen’s picture

svenryen commented

Thanks for the work, all 3 of you.

@BrechtRyckaert: I'm reading your comment, and it says there are no issues in Firefox *before* you applied the patch. Can you confirm that? The rest of us *had* issues with the formatting before the patch, but not after.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

So the point of stark is to have minimal css and styling - it removes the addition of normalize.css (which would fix this) - so the question is what is the purpose of stark and is having a completely working admin UI from a visual perspective the goal?

  • alexpott committed 8dfea8e on 8.0.x 
    Issue #2282133 by basvredeling | joachim: Fixed fieldsets are broken in...

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: stark_firefox_compatibility-2282133-6.patch, failed testing.

cilefen’s picture

cilefen commented
Status: Needs work » Fixed

This should be "Fixed".

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.