In a clean D6 site

Created Event content type and changed some default settings. The Body field label was changed to: Description.

After migrating to a clean D8 site

The field in the new Event content type is named Body. The changed value was not migrated over.

CommentFileSizeAuthor
#5 body_field_label-2281481-5.patch1.88 KBultimike
#2 drupal-migrate-body-2281481-2.patch540 bytescyu
#1 migrate_drupal-body-label-test-2281481.patch2.71 KBtommyk

Comments

tommyk’s picture

tommyk commented
StatusFileSize
new migrate_drupal-body-label-test-2281481.patch2.71 KB

Added a patch that shows the test failing.

cyu’s picture

cyu commented
Status: Active » Needs review
StatusFileSize
new drupal-migrate-body-2281481-2.patch540 bytes

I was able to replicate this problem on a basic install. Verified that test in comment 1 fails.

After applying the attached patch, the body label was migrated as expected and the test in comment 1 passes.

hosef’s picture

hosef commented
Status: Needs review » Needs work

I tried this on a live migration, and the body labels are still not being migrated. I did some debugging and found that create_body_label is not always passed to the node_type creation. I don't yet know what is causing it to not get passed.

cyu’s picture

cyu commented

hosef: Any chance you'd be able to write a test or describe the situation that demonstrates this failure? I've been unable to replicate the behavior you describe. Are some of your body field labels getting properly migrated and some still coming across generically as "Body" when they should be something else? Does applying the patch cause any difference in the results of your migration?

I'm fairly unfamiliar with the code, but making that one line change got the supplied test to pass and got my simple migrations working so I'm unsure how to dig deeper without some fail situations.

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Status: Needs work » Needs review
StatusFileSize
new body_field_label-2281481-5.patch1.88 KB

I've confirmed this is an issue and that @hosef's fix solves the problem.

I'm attaching a patch that adds a modification to the existing test to support the fix.

Thanks,
-mike

hosef’s picture

hosef commented

@cYu was the one who posted the fix.

benjy’s picture

benjy commented
Status: Needs review » Reviewed & tested by the community

Looks good.

  • alexpott committed 052090f on 8.x 
    Issue #2281481 by ultimike, cYu, TommyK: Fixed D6 Body field label -> D8...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 052090f and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.