Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
6 Jun 2014 at 14:24 UTC
Updated:
27 Jun 2014 at 04:49 UTC
Jump to comment: Most recent
Comments
Comment #1
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxamme2281265git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
amme commentedComment #3
amme commentedComment #4
tr commentedA few lines of code which implement an Ubercart hook isn't enough to grant full git access. I personally don't see the need for this module - the reason the hook exists in the first place is to do just this.
Comment #5
gisleI'll have to agree with TR on this one. This project (consisting of 17 lines of PHP code) is just namespace pollution. If the OP thinks there is a need for a demonstration of how this hook works, the 17 lines should be posted as part of the community documentation for Übercart.
Comment #6
amme commentedThanks for feedbacks.
Ok. It's useless as module. Added it to documentation here.
Comment #7
tr commentedThanks for adding that documentation page. It looks good.