When linkit is used with ckeditor, it would be great if the plugin used the default ckeditor link icon which includes a nice hidpi icon.

CommentFileSizeAuthor
#4 linkit-2x.png14.78 KBtanc
#3 hidpi_ckeditor_icons-2280511-3.patch5.07 KBtanc
#1 hidpi_ckeditor_icons-2280511-1.patch3.91 KBtanc

Comments

tanc’s picture

tanc
he/him
Primary language English
Location Italy
commented
StatusFileSize
new hidpi_ckeditor_icons-2280511-1.patch3.91 KB

Attached a patch with icons and changes to the plugin definition to use the icons.

anon’s picture

anon
Primary language Swedish
Location Gothenburg
commented
Status: Active » Needs work

We have to make the Linkit icon different from the original logo as you could use both at the same time.
If we have the same then, it will confuse users.

And why do the patch change the label for?

tanc’s picture

tanc
he/him
Primary language English
Location Italy
commented
Title: Use ckeditor's link and hidpi icons » New icons for links in CKEditor
StatusFileSize
new hidpi_ckeditor_icons-2280511-3.patch5.07 KB

I've created a new icon for linkit which mimics the usual one by including a plus in the lower right. I've also restored the label (not sure why I removed that in last patch).

tanc’s picture

tanc
he/him
Primary language English
Location Italy
commented
StatusFileSize
new linkit-2x.png14.78 KB

hiDPI icons

anon’s picture

anon
Primary language Swedish
Location Gothenburg
commented

That is awesome!

  • anon committed 79d9121 on 7.x-3.x authored by tanc 
    Fixed #2280511 by tanc - New icons for links in CKEditor.
anon’s picture

anon
Primary language Swedish
Location Gothenburg
commented
Status: Needs work » Fixed

Thanks tanc for the patch. I have commited it now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.