Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up to #1939092: Convert theme_mark() to Twig
Blocked on: #939462: Specific preprocess functions for theme hook suggestions are not invoked
Problem/Motivation
- The
mark
theme hook is really just a "tag" with "attributes" and a "value" (one line, more or less, template) - The
mark
theme hook is not extensible (cannot add classes via a preprocess function, must override the template).
Proposed resolution
- Convert all invocations of
'#theme' => 'mark'
to'#type' => 'html_tag__mark'
- Move data logic from the template to a preprocess function.
- Populate the attributes array with the correct classes (based on constants currently).
Remaining tasks
- Create patch
User interface changes
None
API changes
Conversion of a theme hook into a different theme hook suggestion?
Comments
Comment #1
star-szrComment #2
star-szrWe could potentially do this in a later 8.x.x release but I think it's too late for 8.0.x, bumping.
Comment #7
joelpittetThis could be possible yet still *maybe*... Reopening to deal with it.
Comment #10
markhalliwellThis will require
#type
to take theme hook like suggestions.Comment #19
catchThe blocker was committed some time ago.