The Isotope file is now callled isotope.pkgd.min.js instead of the older (V1) name of jquery.isotope.min.js.

I figured maybe its time to start a discussion around shifting to V2, as it may help to clean up some module code?

Thoughts?

Comments

kreynen’s picture

kreynen commented
Status: Active » Needs work

@Chris Gillis,

I got back from Austin late last night. I spent 3 days before DrupalCon started working with the other developers working on issues related to https://drupal.org/project/cm_starterkit_difficult. I updated modules in the morning before sessions, during sessions, and late into the night while much of the Drupal "community" that now attends these conferences was too drunk carry on a conversation... let alone code. I stayed for just the start of the DrupalCon so I could get home to my wife and 6mo. old.

This is not what I wanted to see in my inbox the morning I got back.

I understand that you are trying to help, but this is not a good way to go about it. I changed the title of #1743158: Add FullCalendar like check for .js file to remind myself to add a check to see if the .js files required are in the correct location (the way the FullCalendar module does it) so I didn't have to respond to so many support requests about the module not working that were really just users not following directions. If the v2 version of the module is going to require isotope.pkgd.min.js instead of jquery.isotope.min.js, that is even more important.

Now, instead of continuing to work on the code I had been writing on the plan, I have to review all of the issues you closed.

If you really want to help with this module, use my Drupal.org contact to shoot me an email explaining why you are qualified to help and what you'd want to do. I see that you have some sandbox modules, but nothing promoted to a full module yet. I've helped several people who have built sites in Drupal for several years understand the special sauce that is the Drupal.org issues queues, git process, and release packaging.

In the future, don't just assume that clearing issues for a queue is actually helping.

- Kevin

Chris Gillis’s picture

Chris Gillis commented

Hey Kevin,

Sorry to hear that mate. I certainly did assume that clearing issues from the queue was helping. I'm planning to use this module on a couple of sites and noticed that a lot of the issues had been languishing for years. I decided to start reviewing existing patches, rolling new ones where necessary, and closing some of the ancient support requests, so I could get this thing as stable as possible before I push to production.

As you said, I am not a maintainer of any module, and certainly defer to your experience in that area. I'd be happy to give my time to help take care of this module if that's something you would like me to do, otherwise I'm sorry for taking up your time, and I'll just patch it for my own use and get on with life...

Thanks for all of your work contributing to the community.

-Chris

Chris Gillis’s picture

Chris Gillis commented
Status: Needs work » Fixed

Fixed in 7.x-2.0-beta1.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.