As with Panelizer, the logic for determining whether to enable & show the "New revision" option is incorrect, it's using an entity flag that determines whether revisions are available at all to decide whether one is created by default. Instead, it should disable it by default, but for certain entity bundles (e.g. content types) check whether that setting was overridden.

Comments

damienmckenna’s picture

Status: Active » Needs review
StatusFileSize
new2.6 KB

Ok, so it is correct, it's just a little messy.

damienmckenna’s picture

Title: Don't enable new revision by default » Clean up revision-related code
damienmckenna’s picture

StatusFileSize
new2.72 KB

Additional tweaks.

danepowell’s picture

Status: Needs review » Reviewed & tested by the community

Looks good

damienmckenna’s picture

Status: Reviewed & tested by the community » Fixed

@Dane: Thanks for the review. Committed.

  • DamienMcKenna committed 3970746 on 7.x-1.x
    Issue #2277375 by DamienMcKenna: Tidied up the code for handling...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

damienmckenna’s picture