Problem/Motivation

#2275491: CKEditor does not support the "readonly" attribute adds a work-around in Drupal because CKEditor does not yet natively support the readonly attribute. Once https://dev.ckeditor.com/ticket/12036 lands, though, we will need to remove that work-around.

Proposed resolution

Wait for CKEditor 4.5 to be released, then remove the work-around from #2275491.

Steps to test

  1. Add a second language
  2. Enable Configuration Translation
  3. Add a Global: Text area to a view
  4. Translate that view
  5. Verify that the Source part for the text area is disabled
  6. Apply patch
  7. Clear browser cache
  8. Verify that the Source part for the text area is (still) disabled

A video of the views translation screen in the above scenario

Remaining tasks

  1. Wait.
  2. Remove work-around.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#8 ct-ckeditor-readonly.PNG98.03 KBtstoeckler
#7 ckeditor_readonly_workaround_obsolete-2276187-7.patch943 byteswim leers

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Remove the » Remove the CKEditor readonly attribute support work-around
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +Needs upstream bugfix
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Priority: Normal » Minor
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

This has now been fixed upstream: http://dev.ckeditor.com/ticket/12036#comment:7.

This is now blocked on the release of CKEditor 4.5, and Drupal 8 upgrading to that version.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Remove the CKEditor readonly attribute support work-around » [PP-2] Remove the CKEditor readonly attribute support work-around

Yay, we're now actually updating to CKE 4.5: #2521820: Update CKEditor library to 4.5.3. So we'll be able to fix this soon.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#2521820: Update CKEditor library to 4.5.3
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: [PP-2] Remove the CKEditor readonly attribute support work-around » Remove the CKEditor readonly attribute support work-around
Assigned: Unassigned » tstoeckler
Status: Postponed » Needs review
Issue tags: -Needs upstream bugfix +Quick fix, +Needs manual testing
StatusFileSize
new ckeditor_readonly_workaround_obsolete-2276187-7.patch943 bytes

#2521820: Update CKEditor library to 4.5.3 and its blocker have landed! This means that the upstream bugfix is now also part of Drupal 8 HEAD. which means we can finally remove our workaround for this :)

Can be tested manually by adding this to \Drupal\text\Plugin\Field\FieldWidget\TextareaWidget::formElement():

$element['#disabled'] = TRUE;

… and going to /node/add/article. All of CKEditor's buttons should be disabled, except the Source button.

Then apply the patch, and check that this is still the case.

Assigning to @tstoeckler for review, he advocated to add this work-around for the Content/Config Translation UI.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new ct-ckeditor-readonly.PNG98.03 KB

Yup, this works as designed.

It is actually possible to see this in the UI now, without any patches (yay! :-))

Updated the issue summary.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Assigned: tstoeckler » Unassigned
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

That's one hell of an impressive screenshot of Inception-like nesting levels :D

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: -Needs manual testing
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

Yeah, the usability of translating Views.... well, it doesn't exist basically. :-/

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 073a3c6 and pushed to 8.0.x. Thanks!

  • alexpott committed 073a3c6 on 8.0.x 
    Issue #2276187 by Wim Leers, tstoeckler: Remove the CKEditor readonly...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.