Implementing hook_variable_info would allow for different smtp servers to be used in a multilingual site through the i18n module.

For more info: https://drupal.org/node/1113374

CommentFileSizeAuthor
#6 smtp-n2274571-6.patch2.2 KBdamienmckenna
#1 smtp-fromname_multilingual-2274571-1-7.patch2.2 KBjaypan

Comments

jaypan’s picture

jaypan
Location Victoria, BC
commented
Category: Feature request » Support request
Status: Active » Needs review
StatusFileSize
new smtp-fromname_multilingual-2274571-1-7.patch2.2 KB

I've run into this issue on a system I'm building now - I need the From Name to be translatable based on the language. I'm attaching a patch that does the following:

1) Implements hook_variable_info(), making smpt_fromname translatable
2) When the from name is generated, it first attempts to get the multilingual value, pulling the value based on the language of the email. If no value is found, then if falls back to the existing code, pulling the value using variable_get().

I'm using this already, and it is working on our system.

Status: Needs review » Needs work

The last submitted patch, 1: smtp-fromname_multilingual-2274571-1-7.patch, failed testing.

jaypan’s picture

jaypan
Location Victoria, BC
commented
Version: 7.x-1.0 » 7.x-1.3
Status: Needs work » Needs review

Jaypan queued 1: smtp-fromname_multilingual-2274571-1-7.patch for re-testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-1.3 » 7.x-1.x-dev
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new smtp-n2274571-6.patch2.2 KB

Reuploading to trigger the new testbot.

Status: Needs review » Needs work

The last submitted patch, 6: smtp-n2274571-6.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2651788: Plan for SMTP 7.x-1.4 release

This would be safe to include in the next release.

  • wundo committed abbbb64 on 7.x-1.x authored by DamienMcKenna 
    Issue #2274571 by DamienMcKenna, Jaypan: Implement hook_variable_info
wundo’s picture

wundo commented
Status: Needs review » Fixed

  • wundo committed abbbb64 on 7.x-2.x authored by DamienMcKenna 
    Issue #2274571 by DamienMcKenna, Jaypan: Implement hook_variable_info

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.